Changeset 247404 in webkit

Timestamp:

Jul 12, 2019 3:51:47 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Enable client certificate authentication unit test
​https://bugs.webkit.org/show_bug.cgi?id=199735

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-07-12
Reviewed by Chris Dumez.

• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TEST):
I originally wrote this in ​https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
I found what was crashing. I was reading out of bounds on my vector of 2 strings :(

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-07-12  Alex Christensen  <achristensen@webkit.org>
+
+        Enable client certificate authentication unit test
+        https://bugs.webkit.org/show_bug.cgi?id=199735
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
+        (TEST):
+        I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
+        I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
+
 2019-07-12  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm

@@ -146 +146 @@
 
 #if HAVE(SEC_KEY_PROXY)
-TEST(Challenge, DISABLED_ClientCertificate)
+TEST(Challenge, ClientCertificate)
 {
     using namespace TestWebKitAPI;
@@ -160 +160 @@
     EXPECT_EQ(methods.size(), 2ull);
     EXPECT_TRUE([methods[0] isEqualToString:NSURLAuthenticationMethodServerTrust]);
-    EXPECT_TRUE([methods[2] isEqualToString:NSURLAuthenticationMethodClientCertificate]);
+    EXPECT_TRUE([methods[1] isEqualToString:NSURLAuthenticationMethodClientCertificate]);
 }
 #endif