Changeset 247418 in webkit

Timestamp:

Jul 13, 2019 10:28:41 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Add accessibility support to WKDataListSuggestionsView.
​https://bugs.webkit.org/show_bug.cgi?id=199772
<rdar://problem/47095851>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-13
Reviewed by Chris Fleizach.

Source/WebCore:

Localizable strings for accessibility announcements.

• en.lproj/Localizable.strings:

Source/WebKit:

Added accessibility announcement notifications to show, dismiss and selection change for the datalist suggestions view.

• UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:

(-[WKDataListSuggestionsView notifyAccessibilityClients:]):
(-[WKDataListSuggestionsView moveSelectionByDirection:]):
(-[WKDataListSuggestionsView invalidate]):
(-[WKDataListSuggestionsView showSuggestionsDropdown:]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/en.lproj/Localizable.strings (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-13  Andres Gonzalez  <andresg_22@apple.com>
+
+        Add accessibility support to WKDataListSuggestionsView.
+        https://bugs.webkit.org/show_bug.cgi?id=199772
+        <rdar://problem/47095851>
+
+        Reviewed by Chris Fleizach.
+
+        Localizable strings for accessibility announcements.
+
+        * en.lproj/Localizable.strings:
+
 2019-07-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/en.lproj/Localizable.strings

@@ -776 +776 @@
 "Subtitles" = "Subtitles";
 
+/* Accessibility announcement for the data list suggestions dropdown going away. */
+"Suggestions list hidden." = "Suggestions list hidden.";
+
+/* Accessibility announcement that the suggestions list became visible. The format argument is for the first option in the list. */
+"Suggestions list visible, %@" = "Suggestions list visible, %@";
+
 /* Undo action name */
 "Superscript (Undo action name)" = "Superscript";

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-13  Andres Gonzalez  <andresg_22@apple.com>
+
+        Add accessibility support to WKDataListSuggestionsView.
+        https://bugs.webkit.org/show_bug.cgi?id=199772
+        <rdar://problem/47095851>
+
+        Reviewed by Chris Fleizach.
+
+        Added accessibility announcement notifications to show, dismiss and selection change for the datalist suggestions view.
+        * UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:
+        (-[WKDataListSuggestionsView notifyAccessibilityClients:]):
+        (-[WKDataListSuggestionsView moveSelectionByDirection:]):
+        (-[WKDataListSuggestionsView invalidate]):
+        (-[WKDataListSuggestionsView showSuggestionsDropdown:]):
+
 2019-07-13  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm

@@ -31 +31 @@
 #import "WebPageProxy.h"
 #import <WebCore/IntRect.h>
+#import <WebCore/LocalizedStrings.h>
 #import <pal/spi/cocoa/NSColorSPI.h>
 
@@ -353 +354 @@
 }
 
+- (void)notifyAccessibilityClients:(NSString *)info
+{
+    NSDictionary<NSAccessibilityNotificationUserInfoKey, id> *userInfo = [NSDictionary dictionaryWithObjectsAndKeys:
+        NSAccessibilityPriorityKey, @(NSAccessibilityPriorityHigh),
+        NSAccessibilityAnnouncementKey, info, nil];
+    NSAccessibilityPostNotificationWithUserInfo(NSApp, NSAccessibilityAnnouncementRequestedNotification, userInfo);
+}
+
 - (void)moveSelectionByDirection:(const String&)direction
 {
@@ -369 +378 @@
 
     [_table setActiveRow:newSelection];
+
+    // Notify accessibility clients of new selection.
+    NSString *currentSelectedString = [self currentSelectedString];
+    [self notifyAccessibilityClients:currentSelectedString];
 }
 
@@ -384 +397 @@
     [_enclosingWindow close];
     _enclosingWindow = nil;
+
+    // Notify accessibility clients that datalist went away.
+    NSString *info = WEB_UI_STRING("Suggestions list hidden.", "Accessibility announcement for the data list suggestions dropdown going away.");
+    [self notifyAccessibilityClients:info];
 }
 
@@ -400 +417 @@
     [[_view window] addChildWindow:_enclosingWindow.get() ordered:NSWindowAbove];
     [[_table enclosingScrollView] flashScrollers];
+
+    // Notify accessibility clients of datalist becoming visible.
+    NSString *currentSelectedString = [self currentSelectedString];
+    NSString *info = [NSString stringWithFormat:WEB_UI_STRING("Suggestions list visible, %@", "Accessibility announcement that the suggestions list became visible. The format argument is for the first option in the list."), currentSelectedString];
+    [self notifyAccessibilityClients:info];
 }