Changeset 247427 in webkit

Timestamp:

Jul 15, 2019 1:58:52 AM (5 years ago)

Author:

Michael Catanzaro

Message:

[GTK] GitHub breaks on FreeBSD because of "unsupported browser"
​https://bugs.webkit.org/show_bug.cgi?id=199745

Reviewed by Carlos Garcia Campos.

It's been a while since I last updated the fake version numbers in our user agent, both for
the user agent quirks for naughty websites and also the Safari version in our standard user
agent. Update them. This should fix github.com on FreeBSD at least. I also noticed some
wonkiness on Google Docs recently that I thought required this update, but I didn't do
anything about it at the time because I wasn't able to reproduce the issue when I tried
again later.

This could absolutely break websites, because the web is awful, but that's calculated risk.

• platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::stringForQuirk):

• platform/glib/UserAgentGLib.cpp:

(WebCore::buildUserAgentString):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/UserAgentQuirks.cpp (modified) (1 diff)
• platform/glib/UserAgentGLib.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] GitHub breaks on FreeBSD because of "unsupported browser"
+        https://bugs.webkit.org/show_bug.cgi?id=199745
+
+        Reviewed by Carlos Garcia Campos.
+
+        It's been a while since I last updated the fake version numbers in our user agent, both for
+        the user agent quirks for naughty websites and also the Safari version in our standard user
+        agent. Update them. This should fix github.com on FreeBSD at least. I also noticed some
+        wonkiness on Google Docs recently that I thought required this update, but I didn't do
+        anything about it at the time because I wasn't able to reproduce the issue when I tried
+        again later.
+
+        This could absolutely break websites, because the web is awful, but that's calculated risk.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::UserAgentQuirks::stringForQuirk):
+        * platform/glib/UserAgentGLib.cpp:
+        (WebCore::buildUserAgentString):
+
 2019-07-14  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/UserAgentQuirks.cpp

@@ -149 +149 @@
     case NeedsChromeBrowser:
         // Get versions from https://chromium.googlesource.com/chromium/src.git
-        return "Chrome/58.0.3029.81"_s;
+        return "Chrome/75.0.3770.141"_s;
     case NeedsMacintoshPlatform:
-        return "Macintosh; Intel Mac OS X 10_13_4"_s;
+        return "Macintosh; Intel Mac OS X 10_15"_s;
     case NeedsLinuxDesktopPlatform:
         return "X11; Linux x86_64"_s;

trunk/Source/WebCore/platform/glib/UserAgentGLib.cpp

@@ -104 +104 @@
     // Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
     // https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
-    uaString.appendLiteral("Version/11.0 Safari/");
+    uaString.appendLiteral("Version/13.0 Safari/");
     uaString.append(versionForUAString());