Changeset 247436 in webkit
- Timestamp:
- Jul 15, 2019 11:50:29 AM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r247418 r247436 1 2019-07-15 Wenson Hsieh <wenson_hsieh@apple.com> 2 3 REGRESSION: Chase app crashes immediately after authentication 4 https://bugs.webkit.org/show_bug.cgi?id=199798 5 <rdar://problem/53106179> 6 7 Reviewed by Alex Christensen. 8 9 After r247411, we sometimes try to consult `_page` from WKWebView, before WKWebView's `_page` has been set. This 10 happens under a check for -[WKWebView _isEditable], from within -[WKContentView setupInteraction], which happens 11 if the host app is not linked on the iOS 12 SDK or earlier. To mitigate this, simply add a null check in 12 -_isEditable. 13 14 There's currently no great way to test this, since we don't have a mechanism for simulating linked-on checks. 15 16 * UIProcess/API/Cocoa/WKWebView.mm: 17 (-[WKWebView _isEditable]): 18 1 19 2019-07-13 Andres Gonzalez <andresg_22@apple.com> 2 20 -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
r247414 r247436 4644 4644 - (BOOL)_isEditable 4645 4645 { 4646 return _page ->isEditable();4646 return _page && _page->isEditable(); 4647 4647 } 4648 4648
Note: See TracChangeset
for help on using the changeset viewer.