Changeset 247437 in webkit


Ignore:
Timestamp:
Jul 15, 2019 11:56:48 AM (5 years ago)
Author:
jiewen_tan@apple.com
Message:

[iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
​https://bugs.webkit.org/show_bug.cgi?id=199790
<rdar://problem/52790112>

Reviewed by Brent Fulgham.

Source/WebKit:

On iOS, WebKit relies on a SPI -[WKUIDelegatePrivate _presentingViewControllerForWebView:] to present the
extension UI. However, third party clients often don't implement this SPI. Therefore, WebKit will not be
able to present the extension UI for them.

To be able to show the extension UI for third party WebKit clients, WebKit should unset SOAuthorization.enableEmbeddedAuthorizationViewController
whenever clients don't implement the above SPI such that AppSSO could show the UI in their UI process.

  • UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:

(WebKit::SOAuthorizationSession::start):

Tools:

Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.

  • TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:

(-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
(configureSOAuthorizationWebView):
(TestWebKitAPI::TEST):
(-[TestSOAuthorizationNavigationDelegate init]): Deleted.
(-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
(-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
(-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r247436 r247437  
     12019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
     4        https://bugs.webkit.org/show_bug.cgi?id=199790
     5        <rdar://problem/52790112>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        On iOS, WebKit relies on a SPI -[WKUIDelegatePrivate _presentingViewControllerForWebView:] to present the
     10        extension UI. However, third party clients often don't implement this SPI. Therefore, WebKit will not be
     11        able to present the extension UI for them.
     12
     13        To be able to show the extension UI for third party WebKit clients, WebKit should unset SOAuthorization.enableEmbeddedAuthorizationViewController
     14        whenever clients don't implement the above SPI such that AppSSO could show the UI in their UI process.
     15
     16        * UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
     17        (WebKit::SOAuthorizationSession::start):
     18
    1192019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
    220

  • trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm

    r247410 r247437  
    3434#import "APIUIClient.h"
    3535#import "SOAuthorizationLoadPolicy.h"
    36 #import "WKUIDelegate.h"
     36#import "WKUIDelegatePrivate.h"
    3737#import "WebPageProxy.h"
    3838#import "WebSiteDataStore.h"
    … …  
    130130        [m_soAuthorization setAuthorizationOptions:authorizationOptions];
    131131
     132#if PLATFORM(IOS)
     133        if (![fromWebPageProxy(*m_page).UIDelegate respondsToSelector:@selector(_presentingViewControllerForWebView:)])
     134            [m_soAuthorization setEnableEmbeddedAuthorizationViewController:NO];
     135#endif
     136
    132137        auto *nsRequest = m_navigationAction->request().nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
    133138        [m_soAuthorization beginAuthorizationWithURL:nsRequest.URL httpHeaders:nsRequest.allHTTPHeaderFields httpBody:nsRequest.HTTPBody];

  • trunk/Tools/ChangeLog

    r247434 r247437  
     12019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
     4        https://bugs.webkit.org/show_bug.cgi?id=199790
     5        <rdar://problem/52790112>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
     10
     11        * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
     12        (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
     13        (configureSOAuthorizationWebView):
     14        (TestWebKitAPI::TEST):
     15        (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
     16        (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
     17        (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
     18        (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
     19        (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
     20
    1212019-07-15  Sihui Liu  <sihui_liu@apple.com>
    222

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm

    r246872 r247437  
    140140@end
    141141
    142 @interface TestSOAuthorizationNavigationDelegate : NSObject <WKNavigationDelegate, WKUIDelegate>
     142@interface TestSOAuthorizationDelegate : NSObject <WKNavigationDelegate, WKUIDelegate>
    143143@property bool isDefaultPolicy;
    144144@property bool shouldOpenExternalSchemes;
    … …  
    148148@end
    149149
    150 @implementation TestSOAuthorizationNavigationDelegate
     150@implementation TestSOAuthorizationDelegate
    151151
    152152- (instancetype)init
    … …  
    208208}
    209209
     210- (UIViewController *)_presentingViewControllerForWebView:(WKWebView *)webView
     211{
     212    return nil;
     213}
     214
    210215@end
    211216
    … …  
    297302};
    298303
    299 static void configureSOAuthorizationWebView(TestWKWebView *webView, TestSOAuthorizationNavigationDelegate *delegate, OpenExternalSchemesPolicy policy = OpenExternalSchemesPolicy::Disallow)
     304static void configureSOAuthorizationWebView(TestWKWebView *webView, TestSOAuthorizationDelegate *delegate, OpenExternalSchemesPolicy policy = OpenExternalSchemesPolicy::Disallow)
    300305{
    301306    [webView setNavigationDelegate:delegate];
    … …  
    332337
    333338    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    334     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     339    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    335340    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    336341
    … …  
    349354
    350355    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    351     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     356    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    352357    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    353358
    … …  
    368373
    369374    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    370     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     375    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    371376    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    372377
    … …  
    391396
    392397    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    393     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     398    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    394399    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    395400
    … …  
    414419
    415420    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    416     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     421    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    417422    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    418423
    … …  
    437442
    438443    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    439     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     444    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    440445    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    441446
    … …  
    467472    Util::run(&authorizationPerformed);
    468473    checkAuthorizationOptions(false, "", 0);
     474#if PLATFORM(MAC)
     475    EXPECT_TRUE(gAuthorization.enableEmbeddedAuthorizationViewController);
     476#elif PLATFORM(IOS)
     477    EXPECT_FALSE(gAuthorization.enableEmbeddedAuthorizationViewController);
     478#endif
    469479
    470480    RetainPtr<NSURL> redirectURL = [[NSBundle mainBundle] URLForResource:@"simple2" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
    … …  
    522532
    523533    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    524     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
    525     configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
     534    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
     535    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
     536    EXPECT_TRUE(gAuthorization.enableEmbeddedAuthorizationViewController);
    526537
    527538    // Force App Links with a request.URL that has a different host than the current one (empty host) and ShouldOpenExternalURLsPolicy::ShouldAllow.
    … …  
    559570    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    560571    // A separate delegate that implements decidePolicyForNavigationAction.
    561     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     572    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    562573    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    563574    [delegate setIsDefaultPolicy:false];
    … …  
    588599
    589600    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    590     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     601    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    591602    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    592603
    … …  
    612623
    613624    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    614     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     625    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    615626    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    616627
    … …  
    647658
    648659    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    649     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     660    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    650661    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    651662
    … …  
    681692
    682693    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    683     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     694    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    684695    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    685696
    … …  
    722733
    723734    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    724     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     735    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    725736    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    726737
    … …  
    746757
    747758    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    748     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     759    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    749760    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    750761
    … …  
    781792
    782793    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    783     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     794    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    784795    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    785796
    … …  
    812823
    813824    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    814     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     825    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    815826    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    816827
    … …  
    845856
    846857    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    847     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     858    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    848859    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    849860
    … …  
    880891
    881892    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    882     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     893    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    883894    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    884895
    … …  
    920931
    921932    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    922     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     933    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    923934    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    924935
    … …  
    946957
    947958    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    948     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     959    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    949960    configureSOAuthorizationWebView(webView.get(), delegate.get());
    950961
    … …  
    968979
    969980    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    970     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     981    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    971982    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    972983
    … …  
    9891000
    9901001    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    991     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1002    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    9921003    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    9931004
    … …  
    10101021
    10111022    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1012     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1023    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    10131024    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    10141025    [delegate setAllowSOAuthorizationLoad:false];
    … …  
    10301041
    10311042    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1032     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1043    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    10331044    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    10341045
    … …  
    10561067
    10571068    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1058     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1069    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    10591070    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    10601071    [delegate setAllowSOAuthorizationLoad:false];
    … …  
    10801091
    10811092    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1082     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1093    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    10831094    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    10841095
    … …  
    11131124
    11141125    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1115     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1126    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    11161127    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    11171128
    … …  
    11451156
    11461157    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1147     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1158    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    11481159    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    11491160
    … …  
    11771188
    11781189    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1179     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1190    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    11801191    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    11811192
    … …  
    12161227
    12171228    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1218     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1229    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    12191230    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    12201231
    … …  
    12531264
    12541265    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1255     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1266    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    12561267    configureSOAuthorizationWebView(webView.get(), delegate.get(), OpenExternalSchemesPolicy::Allow);
    12571268
    … …  
    12831294
    12841295    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1285     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1296    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    12861297    configureSOAuthorizationWebView(webView.get(), delegate.get());
    12871298
    … …  
    13161327
    13171328    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1318     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1329    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    13191330    configureSOAuthorizationWebView(webView.get(), delegate.get());
    13201331
    … …  
    13411352
    13421353    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400) configuration:configuration.get()]);
    1343     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1354    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    13441355    configureSOAuthorizationWebView(webView.get(), delegate.get());
    13451356
    … …  
    13611372
    13621373    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1363     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1374    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    13641375    configureSOAuthorizationWebView(webView.get(), delegate.get());
    13651376
    … …  
    13971408
    13981409    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1399     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1410    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    14001411    configureSOAuthorizationWebView(webView.get(), delegate.get());
    14011412
    … …  
    14301441
    14311442    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1432     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1443    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    14331444    configureSOAuthorizationWebView(webView.get(), delegate.get());
    14341445
    … …  
    14661477
    14671478    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1468     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1479    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    14691480    configureSOAuthorizationWebView(webView.get(), delegate.get());
    14701481
    … …  
    15021513
    15031514    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1504     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1515    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    15051516    configureSOAuthorizationWebView(webView.get(), delegate.get());
    15061517
    … …  
    15381549
    15391550    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1540     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1551    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    15411552    configureSOAuthorizationWebView(webView.get(), delegate.get());
    15421553
    … …  
    15781589
    15791590    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1580     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1591    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    15811592    configureSOAuthorizationWebView(webView.get(), delegate.get());
    15821593
    … …  
    16141625
    16151626    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1616     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1627    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    16171628    configureSOAuthorizationWebView(webView.get(), delegate.get());
    16181629
    … …  
    16541665
    16551666    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1656     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1667    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    16571668    configureSOAuthorizationWebView(webView.get(), delegate.get());
    16581669
    … …  
    17151726
    17161727    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1717     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1728    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    17181729    configureSOAuthorizationWebView(webView.get(), delegate.get());
    17191730
    … …  
    17501761
    17511762    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1752     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1763    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    17531764    configureSOAuthorizationWebView(webView.get(), delegate.get());
    17541765
    … …  
    17741785
    17751786    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1776     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1787    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    17771788    configureSOAuthorizationWebView(webView.get(), delegate.get());
    17781789    [delegate setAllowSOAuthorizationLoad:false];
    … …  
    18021813
    18031814    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
    1804     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1815    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    18051816    configureSOAuthorizationWebView(webView.get(), delegate.get());
    18061817    [delegate setIsAsyncExecution:true];
    … …  
    18371848
    18381849    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1839     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1850    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    18401851    configureSOAuthorizationWebView(webView.get(), delegate.get());
    18411852    [delegate setAllowSOAuthorizationLoad:false];
    … …  
    18621873
    18631874    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1864     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1875    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    18651876    configureSOAuthorizationWebView(webView.get(), delegate.get());
    18661877
    … …  
    18791890
    18801891    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1881     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1892    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    18821893    configureSOAuthorizationWebView(webView.get(), delegate.get());
    18831894
    … …  
    19021913
    19031914    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1904     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1915    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    19051916    configureSOAuthorizationWebView(webView.get(), delegate.get());
    19061917
    … …  
    19321943
    19331944    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1934     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1945    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    19351946    configureSOAuthorizationWebView(webView.get(), delegate.get());
    19361947
    … …  
    19601971
    19611972    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1962     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     1973    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    19631974    configureSOAuthorizationWebView(webView.get(), delegate.get());
    19641975
    … …  
    19942005
    19952006    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    1996     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2007    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    19972008    configureSOAuthorizationWebView(webView.get(), delegate.get());
    19982009
    … …  
    20212032
    20222033    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    2023     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2034    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    20242035    configureSOAuthorizationWebView(webView.get(), delegate.get());
    20252036
    … …  
    20522063
    20532064    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    2054     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2065    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    20552066    configureSOAuthorizationWebView(webView.get(), delegate.get());
    20562067
    … …  
    20702081
    20712082    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    2072     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2083    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    20732084    configureSOAuthorizationWebView(webView.get(), delegate.get());
    20742085    [delegate setAllowSOAuthorizationLoad:false];
    … …  
    20932104
    20942105    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    2095     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2106    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    20962107    configureSOAuthorizationWebView(webView.get(), delegate.get());
    20972108    [delegate setIsAsyncExecution:true];
    … …  
    21182129
    21192130    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    2120     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2131    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    21212132    configureSOAuthorizationWebView(webView.get(), delegate.get());
    21222133    [delegate setAllowSOAuthorizationLoad:false];
    … …  
    21612172
    21622173    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    2163     auto delegate = adoptNS([[TestSOAuthorizationNavigationDelegate alloc] init]);
     2174    auto delegate = adoptNS([[TestSOAuthorizationDelegate alloc] init]);
    21642175    configureSOAuthorizationWebView(webView.get(), delegate.get());
    21652176
Note: See TracChangeset for help on using the changeset viewer.