Changeset 247571 in webkit

Timestamp:

Jul 18, 2019 12:06:35 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Rebase fast/forms/ios/delete-in-input-in-iframe.html after r244141
​https://bugs.webkit.org/show_bug.cgi?id=199875
<rdar://problem/50060561>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-07-18
Reviewed by Megan Gardner.

In r202295, we added an ios-specific quirk to prevent scrolling on iOS because of UIKit/WebKit scrolling discrepancies.
In r244141, we changed the scrolling behavior to be more like macOS, and the test was broken. Since this was an intentional
change and the bugs reported in rdar://problem/26805722 (initially fixed by r202295) and rdar://problem/49225507 (fixed by r244141)
are both behaving as desired, the intentional change in r244141 should be reflected by new test expectations.
We do want typing in an input field in an iframe to scroll as we type.

• fast/forms/ios/delete-in-input-in-iframe-expected.txt:
• fast/forms/ios/delete-in-input-in-iframe.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/forms/ios/delete-in-input-in-iframe-expected.txt (modified) (1 diff)
• fast/forms/ios/delete-in-input-in-iframe.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-07-18  Alex Christensen  <achristensen@webkit.org>
+
+        Rebase fast/forms/ios/delete-in-input-in-iframe.html after r244141
+        https://bugs.webkit.org/show_bug.cgi?id=199875
+        <rdar://problem/50060561>
+
+        Reviewed by Megan Gardner.
+
+        In r202295, we added an ios-specific quirk to prevent scrolling on iOS because of UIKit/WebKit scrolling discrepancies.
+        In r244141, we changed the scrolling behavior to be more like macOS, and the test was broken.  Since this was an intentional
+        change and the bugs reported in rdar://problem/26805722 (initially fixed by r202295) and rdar://problem/49225507 (fixed by r244141)
+        are both behaving as desired, the intentional change in r244141 should be reflected by new test expectations.
+        We do want typing in an input field in an iframe to scroll as we type.
+
+        * fast/forms/ios/delete-in-input-in-iframe-expected.txt:
+        * fast/forms/ios/delete-in-input-in-iframe.html:
+
 2019-07-18  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt

@@ -1 +1 @@
 Tests that typing into a text input in an iframe should not scroll.
 
-PASS: page did not scroll.
+PASS: page scrolled to 1143
 Click to focus input
 

trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html

@@ -40 +40 @@
     function pageDidScroll()
     {
-        document.getElementById('result').textContent = 'FAIL: page scrolled to ' + document.scrollingElement.scrollTop;
+        document.getElementById('result').textContent = 'PASS: page scrolled to ' + document.scrollingElement.scrollTop;
     }
 
@@ -77 +77 @@
 <p>Tests that typing into a text input in an iframe should not scroll.</p>
 <div id="result">
-    PASS: page did not scroll.
+    FAIL: page did not scroll.
 </div>