Changeset 247641 in webkit

Timestamp:

Jul 19, 2019 2:11:35 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Remove some unneeded code in MathOperator
​https://bugs.webkit.org/show_bug.cgi?id=199935

Patch by Rob Buis <​rbuis@igalia.com> on 2019-07-19
Reviewed by Frédéric Wang.

The initialize method is unneeded since the member
variables all use default initialization.

No new tests, not changing behavior.

• rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::MathOperator):
(WebCore::MathOperator::GlyphAssemblyData::initialize): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/mathml/MathOperator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-19  Rob Buis  <rbuis@igalia.com>
+
+        Remove some unneeded code in MathOperator
+        https://bugs.webkit.org/show_bug.cgi?id=199935
+
+        Reviewed by Frédéric Wang.
+
+        The initialize method is unneeded since the member
+        variables all use default initialization.
+
+        No new tests, not changing behavior.
+
+        * rendering/mathml/MathOperator.cpp:
+        (WebCore::MathOperator::MathOperator):
+        (WebCore::MathOperator::GlyphAssemblyData::initialize): Deleted.
+
 2019-07-18  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/rendering/mathml/MathOperator.cpp

@@ -87 +87 @@
 };
 
-void MathOperator::GlyphAssemblyData::initialize()
-{
-    topOrRightCodePoint = 0;
-    topOrRightFallbackGlyph = 0;
-    extensionCodePoint = 0;
-    extensionFallbackGlyph = 0;
-    bottomOrLeftCodePoint = 0;
-    bottomOrLeftFallbackGlyph = 0;
-    middleCodePoint = 0;
-    middleFallbackGlyph = 0;
-}
-    
 MathOperator::MathOperator()
 {
-    m_assembly.initialize();
     m_variantGlyph = 0;
 }