Changeset 247677 in webkit


Ignore:
Timestamp:
Jul 21, 2019 3:15:19 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Add accessibilityInsertText for text insertion in edit fields.
​https://bugs.webkit.org/show_bug.cgi?id=199973

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-21
Reviewed by Chris Fleizach.

Renamed accessibilityInsertText to _accessibilityInsertText.

Source/WebCore:

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityInsertText:]):
(-[WebAccessibilityObjectWrapper accessibilityInsertText:]): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper _accessibilityInsertText:]):
(-[WebAccessibilityObjectWrapper accessibilityInsertText:]): Deleted.

Tools:

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::insertText):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::insertText):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::insertText):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::insertText):

Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r247676 r247677  
     12019-07-21  Andres Gonzalez  <andresg_22@apple.com>
     2
     3        Add accessibilityInsertText for text insertion in edit fields.
     4        https://bugs.webkit.org/show_bug.cgi?id=199973
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Renamed accessibilityInsertText to _accessibilityInsertText.
     9
     10        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     11        (-[WebAccessibilityObjectWrapper _accessibilityInsertText:]):
     12        (-[WebAccessibilityObjectWrapper accessibilityInsertText:]): Deleted.
     13        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
     14        (-[WebAccessibilityObjectWrapper _accessibilityInsertText:]):
     15        (-[WebAccessibilityObjectWrapper accessibilityInsertText:]): Deleted.
     16
    1172019-07-21  Saam Barati  <sbarati@apple.com>
    218

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r247671 r247677  
    25622562}
    25632563
    2564 - (BOOL)accessibilityInsertText:(NSString *)text
     2564- (BOOL)_accessibilityInsertText:(NSString *)text
    25652565{
    25662566    if (![self _prepareAccessibilityCall])

  • trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

    r247671 r247677  
    38313831}
    38323832
    3833 - (BOOL)accessibilityInsertText:(NSString *)text
     3833- (BOOL)_accessibilityInsertText:(NSString *)text
    38343834{
    38353835    if (![self updateObjectBackingStore])

  • trunk/Tools/ChangeLog

    r247673 r247677  
     12019-07-21  Andres Gonzalez  <andresg_22@apple.com>
     2
     3        Add accessibilityInsertText for text insertion in edit fields.
     4        https://bugs.webkit.org/show_bug.cgi?id=199973
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Renamed accessibilityInsertText to _accessibilityInsertText.
     9
     10        * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
     11        (AccessibilityUIElement::insertText):
     12        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
     13        (AccessibilityUIElement::insertText):
     14        * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
     15        (WTR::AccessibilityUIElement::insertText):
     16        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
     17        (WTR::AccessibilityUIElement::insertText):
     18
    1192019-07-20  Chris Dumez  <cdumez@apple.com>
    220

  • trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm

    r247671 r247677  
    7676- (NSArray *)elementsForRange:(NSRange)range;
    7777- (NSString *)selectionRangeString;
    78 - (BOOL)accessibilityInsertText:(NSString *)text;
     78- (BOOL)_accessibilityInsertText:(NSString *)text;
    7979- (CGPoint)accessibilityClickPoint;
    8080- (void)accessibilityModifySelection:(WebCore::TextGranularity)granularity increase:(BOOL)increase;
    … …  
    488488bool AccessibilityUIElement::insertText(JSStringRef text)
    489489{
    490     return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
     490    return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
    491491}
    492492

  • trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

    r247671 r247677  
    7272@interface NSObject (WebKitAccessibilityAdditions)
    7373- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string;
    74 - (BOOL)accessibilityInsertText:(NSString *)text;
     74- (BOOL)_accessibilityInsertText:(NSString *)text;
    7575- (NSArray *)accessibilityArrayAttributeValues:(NSString *)attribute index:(NSUInteger)index maxCount:(NSUInteger)maxCount;
    7676- (NSUInteger)accessibilityIndexOfChild:(id)child;
    … …  
    17211721{
    17221722    BEGIN_AX_OBJC_EXCEPTIONS
    1723     return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
     1723    return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
    17241724    END_AX_OBJC_EXCEPTIONS
    17251725    return false;

  • trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

    r247671 r247677  
    5959- (void)_accessibilitySetSelectedTextRange:(NSRange)range;
    6060- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string;
    61 - (BOOL)accessibilityInsertText:(NSString *)text;
     61- (BOOL)_accessibilityInsertText:(NSString *)text;
    6262- (void)accessibilitySetPostedNotificationCallback:(AXPostedNotificationCallback)function withContext:(void*)context;
    6363- (CGFloat)_accessibilityMinValue;
    … …  
    11671167bool AccessibilityUIElement::insertText(JSStringRef text)
    11681168{
    1169     return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
     1169    return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
    11701170}
    11711171

  • trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

    r247671 r247677  
    7676@interface NSObject (WebKitAccessibilityAdditions)
    7777- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string;
    78 - (BOOL)accessibilityInsertText:(NSString *)text;
     78- (BOOL)_accessibilityInsertText:(NSString *)text;
    7979- (NSArray *)accessibilityArrayAttributeValues:(NSString *)attribute index:(NSUInteger)index maxCount:(NSUInteger)maxCount;
    8080- (NSUInteger)accessibilityIndexOfChild:(id)child;
    … …  
    18821882{
    18831883    BEGIN_AX_OBJC_EXCEPTIONS
    1884     return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
     1884    return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
    18851885    END_AX_OBJC_EXCEPTIONS
    18861886    return false;
Note: See TracChangeset for help on using the changeset viewer.