Changeset 247682 in webkit


Ignore:
Timestamp:
Jul 22, 2019 7:25:00 AM (5 years ago)
Author:
clopez@igalia.com
Message:

[webkitpy] Add an unit test for setting up the driver environment without starting it.
https://bugs.webkit.org/show_bug.cgi?id=199945

Reviewed by Michael Catanzaro.

This adds an unit test for the change implemented in r247663.

  • Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_setup_environ_base_vars):
(DriverTest):
(DriverTest.test_setup_environ_without_starting_driver):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r247679 r247682  
     12019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [webkitpy] Add an unit test for setting up the driver environment without starting it.
     4        https://bugs.webkit.org/show_bug.cgi?id=199945
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        This adds an unit test for the change implemented in r247663.
     9
     10        * Scripts/webkitpy/port/driver_unittest.py:
     11        (DriverTest.test_setup_environ_base_vars):
     12        (DriverTest):
     13        (DriverTest.test_setup_environ_without_starting_driver):
     14
    1152019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
    216
  • trunk/Tools/Scripts/webkitpy/port/driver_unittest.py

    r247642 r247682  
    380380                    self.assertEqual(environment_driver_test[var], environ_keep_yes[var])
    381381
     382    def test_setup_environ_without_starting_driver(self):
     383        environ_user = {'WEBKIT_OUTPUTDIR': '/opt/webkit/WebKitBuild/Release'}
     384        with patch('os.environ', environ_user):
     385            port = self.make_port()
     386            driver = Driver(port, None, pixel_tests=False)
     387            self.assertEqual(driver._driver_tempdir, None)
     388            environ_driver = driver._setup_environ_for_test()
     389            self.assertNotEqual(driver._driver_tempdir, None)
     390            self.assertTrue(port._filesystem.isdir(str(driver._driver_tempdir)))
     391            for var in environ_driver:
     392                self.assertNotEqual(var, None)
     393                self.assertNotEqual(environ_driver[var], None)
     394
    382395    def test_create_temporal_home_dir(self):
    383396        environ_user = {'HOME': '/home/igalia'}
Note: See TracChangeset for help on using the changeset viewer.