Changeset 247699 in webkit

Timestamp:

Jul 22, 2019 1:24:05 PM (5 years ago)

Author:

pvollan@apple.com

Message:

Prewarmed font does not find any matches
​https://bugs.webkit.org/show_bug.cgi?id=200007

Reviewed by Brent Fulgham.

Prewarming the font name 'SF Pro Text' does not find any matches. The font name ".SF NS Text/Display"
should be used instead. Also add 'Lucida Grande' to the list of prewarmed font, since it is used as
fallback font in many cases.

No new tests, covered by existing tests.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::fontFamiliesForPrewarming):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cocoa/FontCacheCoreText.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-22  Per Arne Vollan  <pvollan@apple.com>
+
+        Prewarmed font does not find any matches
+        https://bugs.webkit.org/show_bug.cgi?id=200007
+
+        Reviewed by Brent Fulgham.
+
+        Prewarming the font name 'SF Pro Text' does not find any matches. The font name ".SF NS Text/Display"
+        should be used instead. Also add 'Lucida Grande' to the list of prewarmed font, since it is used as
+        fallback font in many cases.
+
+        No new tests, covered by existing tests.
+
+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
+        (WebCore::fontFamiliesForPrewarming):
+
 2019-07-22  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp

@@ -1653 +1653 @@
 {
     static NeverDestroyed<Vector<String>> families = std::initializer_list<String> {
+        ".SF NS Text"_s,
+        ".SF NS Display"_s,
         "Arial"_s,
         "Helvetica"_s,
         "Helvetica Neue"_s,
-        "SF Pro Text"_s,
+        "Lucida Grande"_s,
         "Times"_s,
         "Times New Roman"_s,