Changeset 247706 in webkit

Timestamp:

Jul 22, 2019 4:47:16 PM (5 years ago)

Author:

Jonathan Bedard

Message:

resultsdbpy: Handle case where the previous commit doesn't have the changelog
​https://bugs.webkit.org/show_bug.cgi?id=200015

Reviewed by Aakash Jain.

• resultsdbpy/resultsdbpy/model/repository.py:

(WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/model/repository.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-07-22  Jonathan Bedard  <jbedard@apple.com>
+
+        resultsdbpy: Handle case where the previous commit doesn't have the changelog
+        https://bugs.webkit.org/show_bug.cgi?id=200015
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/model/repository.py:
+        (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
+
 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/model/repository.py

@@ -321 +321 @@
                     if previous_response and previous_response.status_code != 200:
                         continue
-                    if len(current_response.text) == (len(previous_response.text) if previous_response else 0):
+
+                    previous_response_length = 0
+                    if previous_response:
+                        previous_response_length = len(previous_response.text)
+                    if len(current_response.text) == previous_response_length:
                         continue
-
-                    if len(current_response.text) < (len(previous_response.text) if previous_response else 0):
+                    if not previous_response_length or len(current_response.text) < previous_response_length:
                         changelogs[changelog] = current_response.text
                     else: