Changeset 247786 in webkit


Ignore:
Timestamp:
Jul 24, 2019 1:18:50 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Null check CompletionHandler in WebPreviewLoaderClient::didReceivePassword
https://bugs.webkit.org/show_bug.cgi?id=200080
<rdar://problem/37275772>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-07-24
Reviewed by Chris Dumez.

  • WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:

(WebKit::WebPreviewLoaderClient::didReceivePassword):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r247784 r247786  
     12019-07-24  Alex Christensen  <achristensen@webkit.org>
     2
     3        Null check CompletionHandler in WebPreviewLoaderClient::didReceivePassword
     4        https://bugs.webkit.org/show_bug.cgi?id=200080
     5        <rdar://problem/37275772>
     6
     7        Reviewed by Chris Dumez.
     8
     9        * WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:
     10        (WebKit::WebPreviewLoaderClient::didReceivePassword):
     11
    1122019-07-24  Chris Dumez  <cdumez@apple.com>
    213
  • trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp

    r245796 r247786  
    2929#if USE(QUICK_LOOK)
    3030
     31#include "Logging.h"
    3132#include "WebPageProxyMessages.h"
    3233#include "WebProcess.h"
     
    8990{
    9091    ASSERT(passwordCallbacks().contains(pageID));
    91     auto completionHandler = passwordCallbacks().take(pageID);
    92     completionHandler(password);
     92    if (auto completionHandler = passwordCallbacks().take(pageID))
     93        completionHandler(password);
     94    else
     95        RELEASE_LOG_ERROR(Loading, "Discarding a password for a page that did not request one in this process");
    9396}
    9497
Note: See TracChangeset for help on using the changeset viewer.