Changeset 247828 in webkit

Timestamp:

Jul 25, 2019 11:09:59 AM (5 years ago)

Author:

Chris Dumez

Message:

Avoid some unnecessary HashMap copies
​https://bugs.webkit.org/show_bug.cgi?id=200129

Reviewed by Youenn Fablet.

Source/WebCore:

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::addRegistrationFromStore):

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose):

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::connect):

• UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):

• UIProcess/Launcher/ProcessLauncher.h:

(WebKit::ProcessLauncher::create):

• WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/workers/service/server/SWServer.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp (modified) (1 diff)
• WebKit/UIProcess/AuxiliaryProcessProxy.cpp (modified) (1 diff)
• WebKit/UIProcess/Launcher/ProcessLauncher.cpp (modified) (1 diff)
• WebKit/UIProcess/Launcher/ProcessLauncher.h (modified) (2 diffs)
• WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-25  Chris Dumez  <cdumez@apple.com>
+
+        Avoid some unnecessary HashMap copies
+        https://bugs.webkit.org/show_bug.cgi?id=200129
+
+        Reviewed by Youenn Fablet.
+
+        * workers/service/server/SWServer.cpp:
+        (WebCore::SWServer::addRegistrationFromStore):
+
 2019-07-25  Joshua Watt  <JPEW.hacker@gmail.com>
 

trunk/Source/WebCore/workers/service/server/SWServer.cpp

@@ -150 +150 @@
     addRegistration(WTFMove(registration));
 
-    auto worker = SWServerWorker::create(*this, *registrationPtr, data.scriptURL, data.script, data.contentSecurityPolicy, WTFMove(data.referrerPolicy), data.workerType, data.serviceWorkerIdentifier, HashMap<URL, ServiceWorkerContextData::ImportedScript> { data.scriptResourceMap });
+    auto worker = SWServerWorker::create(*this, *registrationPtr, data.scriptURL, data.script, data.contentSecurityPolicy, WTFMove(data.referrerPolicy), data.workerType, data.serviceWorkerIdentifier, WTFMove(data.scriptResourceMap));
     registrationPtr->updateRegistrationState(ServiceWorkerRegistrationState::Active, worker.ptr());
     worker->setState(ServiceWorkerState::Activated);

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-25  Chris Dumez  <cdumez@apple.com>
+
+        Avoid some unnecessary HashMap copies
+        https://bugs.webkit.org/show_bug.cgi?id=200129
+
+        Reviewed by Youenn Fablet.
+
+        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
+        (WebKit::NetworkConnectionToWebProcess::didClose):
+        * UIProcess/AuxiliaryProcessProxy.cpp:
+        (WebKit::AuxiliaryProcessProxy::connect):
+        * UIProcess/Launcher/ProcessLauncher.cpp:
+        (WebKit::ProcessLauncher::ProcessLauncher):
+        * UIProcess/Launcher/ProcessLauncher.h:
+        (WebKit::ProcessLauncher::create):
+        * WebProcess/Plugins/WebPluginInfoProvider.cpp:
+        (WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):
+
 2019-07-25  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

@@ -313 +313 @@
 
 #if ENABLE(INDEXED_DATABASE)
-    auto idbConnections = m_webIDBConnections;
+    auto idbConnections = std::exchange(m_webIDBConnections, { });
     for (auto& connection : idbConnections.values())
         connection->disconnectedFromWebProcess();
-
-    m_webIDBConnections.clear();
 #endif
     

trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

@@ -87 +87 @@
     ProcessLauncher::LaunchOptions launchOptions;
     getLaunchOptions(launchOptions);
-    m_processLauncher = ProcessLauncher::create(this, launchOptions);
+    m_processLauncher = ProcessLauncher::create(this, WTFMove(launchOptions));
 }
 

trunk/Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp

@@ -33 +33 @@
 namespace WebKit {
 
-ProcessLauncher::ProcessLauncher(Client* client, const LaunchOptions& launchOptions)
+ProcessLauncher::ProcessLauncher(Client* client, LaunchOptions&& launchOptions)
     : m_client(client)
-    , m_launchOptions(launchOptions)
+    , m_launchOptions(WTFMove(launchOptions))
     , m_processIdentifier(0)
 {

trunk/Source/WebKit/UIProcess/Launcher/ProcessLauncher.h

@@ -84 +84 @@
     };
 
-    static Ref<ProcessLauncher> create(Client* client, const LaunchOptions& launchOptions)
+    static Ref<ProcessLauncher> create(Client* client, LaunchOptions&& launchOptions)
     {
-        return adoptRef(*new ProcessLauncher(client, launchOptions));
+        return adoptRef(*new ProcessLauncher(client, WTFMove(launchOptions)));
     }
 
@@ -96 +96 @@
 
 private:
-    ProcessLauncher(Client*, const LaunchOptions& launchOptions);
+    ProcessLauncher(Client*, LaunchOptions&&);
 
     void launchProcess();

trunk/Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp

@@ -79 +79 @@
 
     versionsToPolicies.set(versionStringToSet, clientPolicy);
-    policiesByIdentifier.set(bundleIdentifierToSet, versionsToPolicies);
+    policiesByIdentifier.set(bundleIdentifierToSet, WTFMove(versionsToPolicies));
     m_hostsToPluginIdentifierData.set(hostToSet, policiesByIdentifier);