Changeset 247832 in webkit

Timestamp:

Jul 25, 2019 11:28:53 AM (5 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Make visitChildren implementation more idiomatic
​https://bugs.webkit.org/show_bug.cgi?id=200121

Reviewed by Mark Lam.

This patch makes visitChildren implementations more idiomatic: cast, assert, and calling Base::visitChildren.
While this does not find interesting issues, it is still nice to have consistent implementations.
StructureChain::visitChildren missed Base::visitChildren, but it does not have much effect since StructureChain
is immortal cell.

• bytecode/ExecutableToCodeBlockEdge.cpp:

(JSC::ExecutableToCodeBlockEdge::visitChildren):

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::visitChildren):

• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::visitChildren):

• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::visitChildren):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

• runtime/JSImmutableButterfly.cpp:

(JSC::JSImmutableButterfly::visitChildren):

• runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::visitChildren):

• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::visitChildren):

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

• runtime/JSString.cpp:

(JSC::JSString::visitChildren):

• runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::visitChildren):

• runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

• runtime/SymbolTable.cpp:

(JSC::SymbolTable::visitChildren):

• tools/JSDollarVM.cpp:

(JSC::Root::visitChildren):
(JSC::ImpureGetter::visitChildren):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::visitChildren):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/ExecutableToCodeBlockEdge.cpp (modified) (1 diff)
• runtime/AbstractModuleRecord.cpp (modified) (1 diff)
• runtime/FunctionRareData.cpp (modified) (1 diff)
• runtime/JSArrayBufferView.cpp (modified) (1 diff)
• runtime/JSGenericTypedArrayViewInlines.h (modified) (1 diff)
• runtime/JSImmutableButterfly.cpp (modified) (1 diff)
• runtime/JSModuleEnvironment.cpp (modified) (1 diff)
• runtime/JSModuleRecord.cpp (modified) (1 diff)
• runtime/JSPropertyNameEnumerator.cpp (modified) (1 diff)
• runtime/JSString.cpp (modified) (1 diff)
• runtime/SparseArrayValueMap.cpp (modified) (1 diff)
• runtime/StructureChain.cpp (modified) (1 diff)
• runtime/SymbolTable.cpp (modified) (1 diff)
• tools/JSDollarVM.cpp (modified) (2 diffs)
• wasm/js/WebAssemblyModuleRecord.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-07-25  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Make visitChildren implementation more idiomatic
+        https://bugs.webkit.org/show_bug.cgi?id=200121
+
+        Reviewed by Mark Lam.
+
+        This patch makes visitChildren implementations more idiomatic: cast, assert, and calling Base::visitChildren.
+        While this does not find interesting issues, it is still nice to have consistent implementations.
+        StructureChain::visitChildren missed Base::visitChildren, but it does not have much effect since StructureChain
+        is immortal cell.
+
+        * bytecode/ExecutableToCodeBlockEdge.cpp:
+        (JSC::ExecutableToCodeBlockEdge::visitChildren):
+        * runtime/AbstractModuleRecord.cpp:
+        (JSC::AbstractModuleRecord::visitChildren):
+        * runtime/FunctionRareData.cpp:
+        (JSC::FunctionRareData::visitChildren):
+        * runtime/JSArrayBufferView.cpp:
+        (JSC::JSArrayBufferView::visitChildren):
+        * runtime/JSGenericTypedArrayViewInlines.h:
+        (JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
+        * runtime/JSImmutableButterfly.cpp:
+        (JSC::JSImmutableButterfly::visitChildren):
+        * runtime/JSModuleEnvironment.cpp:
+        (JSC::JSModuleEnvironment::visitChildren):
+        * runtime/JSModuleRecord.cpp:
+        (JSC::JSModuleRecord::visitChildren):
+        * runtime/JSPropertyNameEnumerator.cpp:
+        (JSC::JSPropertyNameEnumerator::visitChildren):
+        * runtime/JSString.cpp:
+        (JSC::JSString::visitChildren):
+        * runtime/SparseArrayValueMap.cpp:
+        (JSC::SparseArrayValueMap::visitChildren):
+        * runtime/StructureChain.cpp:
+        (JSC::StructureChain::visitChildren):
+        * runtime/SymbolTable.cpp:
+        (JSC::SymbolTable::visitChildren):
+        * tools/JSDollarVM.cpp:
+        (JSC::Root::visitChildren):
+        (JSC::ImpureGetter::visitChildren):
+        * wasm/js/WebAssemblyModuleRecord.cpp:
+        (JSC::WebAssemblyModuleRecord::visitChildren):
+
 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp

@@ -56 +56 @@
     VM& vm = visitor.vm();
     ExecutableToCodeBlockEdge* edge = jsCast<ExecutableToCodeBlockEdge*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(cell, info());
     Base::visitChildren(cell, visitor);
 

trunk/Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp

@@ -72 +72 @@
 {
     AbstractModuleRecord* thisObject = jsCast<AbstractModuleRecord*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(thisObject, visitor);
     visitor.append(thisObject->m_moduleEnvironment);

trunk/Source/JavaScriptCore/runtime/FunctionRareData.cpp

@@ -55 +55 @@
 {
     FunctionRareData* rareData = jsCast<FunctionRareData*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(cell, info());
     Base::visitChildren(cell, visitor);
 

trunk/Source/JavaScriptCore/runtime/JSArrayBufferView.cpp

@@ -165 +165 @@
 {
     JSArrayBufferView* thisObject = jsCast<JSArrayBufferView*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(cell, visitor);
 

trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h

@@ -517 +517 @@
 {
     JSGenericTypedArrayView* thisObject = jsCast<JSGenericTypedArrayView*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(thisObject, visitor);
 

trunk/Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp

@@ -35 +35 @@
 void JSImmutableButterfly::visitChildren(JSCell* cell, SlotVisitor& visitor)
 {
+    ASSERT_GC_OBJECT_INHERITS(cell, info());
     Base::visitChildren(cell, visitor);
     if (!hasContiguous(cell->indexingType())) {

trunk/Source/JavaScriptCore/runtime/JSModuleEnvironment.cpp

@@ -71 +71 @@
 {
     JSModuleEnvironment* thisObject = jsCast<JSModuleEnvironment*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(thisObject, visitor);
     visitor.appendValues(thisObject->variables(), thisObject->symbolTable()->scopeSize());

trunk/Source/JavaScriptCore/runtime/JSModuleRecord.cpp

@@ -75 +75 @@
 {
     JSModuleRecord* thisObject = jsCast<JSModuleRecord*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(thisObject, visitor);
     visitor.append(thisObject->m_moduleProgramExecutable);

trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp

@@ -88 +88 @@
 void JSPropertyNameEnumerator::visitChildren(JSCell* cell, SlotVisitor& visitor)
 {
+    JSPropertyNameEnumerator* thisObject = jsCast<JSPropertyNameEnumerator*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(cell, visitor);
-    JSPropertyNameEnumerator* thisObject = jsCast<JSPropertyNameEnumerator*>(cell);
     auto locker = holdLock(thisObject->cellLock());
     for (auto& propertyName : thisObject->m_propertyNames)

trunk/Source/JavaScriptCore/runtime/JSString.cpp

@@ -114 +114 @@
 {
     JSString* thisObject = asString(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(thisObject, visitor);
     

trunk/Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp

@@ -215 +215 @@
 void SparseArrayValueMap::visitChildren(JSCell* cell, SlotVisitor& visitor)
 {
+    SparseArrayValueMap* thisObject = jsCast<SparseArrayValueMap*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(cell, visitor);
-    SparseArrayValueMap* thisObject = jsCast<SparseArrayValueMap*>(cell);
     {
         auto locker = holdLock(thisObject->cellLock());

trunk/Source/JavaScriptCore/runtime/StructureChain.cpp

@@ -49 +49 @@
     StructureChain* thisObject = jsCast<StructureChain*>(cell);
     ASSERT_GC_OBJECT_INHERITS(thisObject, info());
+    Base::visitChildren(thisObject, visitor);
     if (WriteBarrier<Structure>* vector = thisObject->m_vector.get()) {
         size_t i = 0;

trunk/Source/JavaScriptCore/runtime/SymbolTable.cpp

@@ -96 +96 @@
 {
     SymbolTable* thisSymbolTable = jsCast<SymbolTable*>(thisCell);
+    ASSERT_GC_OBJECT_INHERITS(thisSymbolTable, info());
     Base::visitChildren(thisSymbolTable, visitor);
 

trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

@@ -223 +223 @@
     static void visitChildren(JSCell* thisObject, SlotVisitor& visitor)
     {
+        ASSERT_GC_OBJECT_INHERITS(thisObject, info());
         Base::visitChildren(thisObject, visitor);
         visitor.addOpaqueRoot(thisObject);
@@ -326 +327 @@
     static void visitChildren(JSCell* cell, SlotVisitor& visitor)
     {
+        ASSERT_GC_OBJECT_INHERITS(cell, info());
         Base::visitChildren(cell, visitor);
         ImpureGetter* thisObject = jsCast<ImpureGetter*>(cell);

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

@@ -82 +82 @@
 {
     WebAssemblyModuleRecord* thisObject = jsCast<WebAssemblyModuleRecord*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
     Base::visitChildren(thisObject, visitor);
     visitor.append(thisObject->m_instance);