Changeset 247832 in webkit
- Timestamp:
- Jul 25, 2019 11:28:53 AM (5 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 16 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r247819 r247832 1 2019-07-25 Yusuke Suzuki <ysuzuki@apple.com> 2 3 [JSC] Make visitChildren implementation more idiomatic 4 https://bugs.webkit.org/show_bug.cgi?id=200121 5 6 Reviewed by Mark Lam. 7 8 This patch makes visitChildren implementations more idiomatic: cast, assert, and calling Base::visitChildren. 9 While this does not find interesting issues, it is still nice to have consistent implementations. 10 StructureChain::visitChildren missed Base::visitChildren, but it does not have much effect since StructureChain 11 is immortal cell. 12 13 * bytecode/ExecutableToCodeBlockEdge.cpp: 14 (JSC::ExecutableToCodeBlockEdge::visitChildren): 15 * runtime/AbstractModuleRecord.cpp: 16 (JSC::AbstractModuleRecord::visitChildren): 17 * runtime/FunctionRareData.cpp: 18 (JSC::FunctionRareData::visitChildren): 19 * runtime/JSArrayBufferView.cpp: 20 (JSC::JSArrayBufferView::visitChildren): 21 * runtime/JSGenericTypedArrayViewInlines.h: 22 (JSC::JSGenericTypedArrayView<Adaptor>::visitChildren): 23 * runtime/JSImmutableButterfly.cpp: 24 (JSC::JSImmutableButterfly::visitChildren): 25 * runtime/JSModuleEnvironment.cpp: 26 (JSC::JSModuleEnvironment::visitChildren): 27 * runtime/JSModuleRecord.cpp: 28 (JSC::JSModuleRecord::visitChildren): 29 * runtime/JSPropertyNameEnumerator.cpp: 30 (JSC::JSPropertyNameEnumerator::visitChildren): 31 * runtime/JSString.cpp: 32 (JSC::JSString::visitChildren): 33 * runtime/SparseArrayValueMap.cpp: 34 (JSC::SparseArrayValueMap::visitChildren): 35 * runtime/StructureChain.cpp: 36 (JSC::StructureChain::visitChildren): 37 * runtime/SymbolTable.cpp: 38 (JSC::SymbolTable::visitChildren): 39 * tools/JSDollarVM.cpp: 40 (JSC::Root::visitChildren): 41 (JSC::ImpureGetter::visitChildren): 42 * wasm/js/WebAssemblyModuleRecord.cpp: 43 (JSC::WebAssemblyModuleRecord::visitChildren): 44 1 45 2019-07-25 Ross Kirsling <ross.kirsling@sony.com> 2 46 -
trunk/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp
r244019 r247832 56 56 VM& vm = visitor.vm(); 57 57 ExecutableToCodeBlockEdge* edge = jsCast<ExecutableToCodeBlockEdge*>(cell); 58 ASSERT_GC_OBJECT_INHERITS(cell, info()); 58 59 Base::visitChildren(cell, visitor); 59 60 -
trunk/Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp
r242776 r247832 72 72 { 73 73 AbstractModuleRecord* thisObject = jsCast<AbstractModuleRecord*>(cell); 74 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 74 75 Base::visitChildren(thisObject, visitor); 75 76 visitor.append(thisObject->m_moduleEnvironment); -
trunk/Source/JavaScriptCore/runtime/FunctionRareData.cpp
r233245 r247832 55 55 { 56 56 FunctionRareData* rareData = jsCast<FunctionRareData*>(cell); 57 ASSERT_GC_OBJECT_INHERITS(cell, info()); 57 58 Base::visitChildren(cell, visitor); 58 59 -
trunk/Source/JavaScriptCore/runtime/JSArrayBufferView.cpp
r246368 r247832 165 165 { 166 166 JSArrayBufferView* thisObject = jsCast<JSArrayBufferView*>(cell); 167 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 167 168 Base::visitChildren(cell, visitor); 168 169 -
trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h
r246368 r247832 517 517 { 518 518 JSGenericTypedArrayView* thisObject = jsCast<JSGenericTypedArrayView*>(cell); 519 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 519 520 Base::visitChildren(thisObject, visitor); 520 521 -
trunk/Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp
r232954 r247832 35 35 void JSImmutableButterfly::visitChildren(JSCell* cell, SlotVisitor& visitor) 36 36 { 37 ASSERT_GC_OBJECT_INHERITS(cell, info()); 37 38 Base::visitChildren(cell, visitor); 38 39 if (!hasContiguous(cell->indexingType())) { -
trunk/Source/JavaScriptCore/runtime/JSModuleEnvironment.cpp
r236697 r247832 71 71 { 72 72 JSModuleEnvironment* thisObject = jsCast<JSModuleEnvironment*>(cell); 73 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 73 74 Base::visitChildren(thisObject, visitor); 74 75 visitor.appendValues(thisObject->variables(), thisObject->symbolTable()->scopeSize()); -
trunk/Source/JavaScriptCore/runtime/JSModuleRecord.cpp
r245040 r247832 75 75 { 76 76 JSModuleRecord* thisObject = jsCast<JSModuleRecord*>(cell); 77 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 77 78 Base::visitChildren(thisObject, visitor); 78 79 visitor.append(thisObject->m_moduleProgramExecutable); -
trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp
r235742 r247832 88 88 void JSPropertyNameEnumerator::visitChildren(JSCell* cell, SlotVisitor& visitor) 89 89 { 90 JSPropertyNameEnumerator* thisObject = jsCast<JSPropertyNameEnumerator*>(cell); 91 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 90 92 Base::visitChildren(cell, visitor); 91 JSPropertyNameEnumerator* thisObject = jsCast<JSPropertyNameEnumerator*>(cell);92 93 auto locker = holdLock(thisObject->cellLock()); 93 94 for (auto& propertyName : thisObject->m_propertyNames) -
trunk/Source/JavaScriptCore/runtime/JSString.cpp
r246490 r247832 114 114 { 115 115 JSString* thisObject = asString(cell); 116 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 116 117 Base::visitChildren(thisObject, visitor); 117 118 -
trunk/Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp
r236900 r247832 215 215 void SparseArrayValueMap::visitChildren(JSCell* cell, SlotVisitor& visitor) 216 216 { 217 SparseArrayValueMap* thisObject = jsCast<SparseArrayValueMap*>(cell); 218 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 217 219 Base::visitChildren(cell, visitor); 218 SparseArrayValueMap* thisObject = jsCast<SparseArrayValueMap*>(cell);219 220 { 220 221 auto locker = holdLock(thisObject->cellLock()); -
trunk/Source/JavaScriptCore/runtime/StructureChain.cpp
r217108 r247832 49 49 StructureChain* thisObject = jsCast<StructureChain*>(cell); 50 50 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 51 Base::visitChildren(thisObject, visitor); 51 52 if (WriteBarrier<Structure>* vector = thisObject->m_vector.get()) { 52 53 size_t i = 0; -
trunk/Source/JavaScriptCore/runtime/SymbolTable.cpp
r246073 r247832 96 96 { 97 97 SymbolTable* thisSymbolTable = jsCast<SymbolTable*>(thisCell); 98 ASSERT_GC_OBJECT_INHERITS(thisSymbolTable, info()); 98 99 Base::visitChildren(thisSymbolTable, visitor); 99 100 -
trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp
r245040 r247832 223 223 static void visitChildren(JSCell* thisObject, SlotVisitor& visitor) 224 224 { 225 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 225 226 Base::visitChildren(thisObject, visitor); 226 227 visitor.addOpaqueRoot(thisObject); … … 326 327 static void visitChildren(JSCell* cell, SlotVisitor& visitor) 327 328 { 329 ASSERT_GC_OBJECT_INHERITS(cell, info()); 328 330 Base::visitChildren(cell, visitor); 329 331 ImpureGetter* thisObject = jsCast<ImpureGetter*>(cell); -
trunk/Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp
r246589 r247832 82 82 { 83 83 WebAssemblyModuleRecord* thisObject = jsCast<WebAssemblyModuleRecord*>(cell); 84 ASSERT_GC_OBJECT_INHERITS(thisObject, info()); 84 85 Base::visitChildren(thisObject, visitor); 85 86 visitor.append(thisObject->m_instance);
Note: See TracChangeset
for help on using the changeset viewer.