Changeset 247842 in webkit


Ignore:
Timestamp:
Jul 25, 2019 3:25:15 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r247806.
https://bugs.webkit.org/show_bug.cgi?id=200141

It is regressing PLT (Requested by youenn on #webkit).

Reverted changeset:

"Disable speculative loading if cache is not to be used for
the load"
https://bugs.webkit.org/show_bug.cgi?id=199644
https://trac.webkit.org/changeset/247806

Location:
trunk
Files:
5 deleted
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r247839 r247842  
     12019-07-25  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r247806.
     4        https://bugs.webkit.org/show_bug.cgi?id=200141
     5
     6        It is regressing PLT (Requested by youenn on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Disable speculative loading if cache is not to be used for
     11        the load"
     12        https://bugs.webkit.org/show_bug.cgi?id=199644
     13        https://trac.webkit.org/changeset/247806
     14
    1152019-07-25  Russell Epstein  <repstein@apple.com>
    216
  • trunk/Source/WebKit/ChangeLog

    r247839 r247842  
     12019-07-25  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r247806.
     4        https://bugs.webkit.org/show_bug.cgi?id=200141
     5
     6        It is regressing PLT (Requested by youenn on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Disable speculative loading if cache is not to be used for
     11        the load"
     12        https://bugs.webkit.org/show_bug.cgi?id=199644
     13        https://trac.webkit.org/changeset/247806
     14
    1152019-07-25  Dean Jackson  <dino@apple.com>
    216
  • trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp

    r247806 r247842  
    276276        return false;
    277277
    278     if (request.requester() == ResourceRequest::Requester::XHR || request.requester() != ResourceRequest::Requester::Fetch)
     278    if (cachePolicyAllowsExpired(request.cachePolicy()))
    279279        return false;
    280280
    281     switch (request.cachePolicy()) {
    282     case WebCore::ResourceRequestCachePolicy::ReturnCacheDataElseLoad:
    283     case WebCore::ResourceRequestCachePolicy::ReturnCacheDataDontLoad:
    284     case WebCore::ResourceRequestCachePolicy::ReloadIgnoringCacheData:
    285         return false;
    286     case WebCore::ResourceRequestCachePolicy::UseProtocolCachePolicy:
    287     case WebCore::ResourceRequestCachePolicy::RefreshAnyCacheData:
    288         return true;
    289     case WebCore::ResourceRequestCachePolicy::DoNotUseAnyCache:
    290         ASSERT_NOT_REACHED();
    291         return false;
    292     }
    293     return false;
     281    return request.requester() != ResourceRequest::Requester::XHR && request.requester() != ResourceRequest::Requester::Fetch;
    294282}
    295283#endif
Note: See TracChangeset for help on using the changeset viewer.