Changeset 247869 in webkit

Timestamp:

Jul 26, 2019 12:17:31 PM (5 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Suite results shouldn't be the landing page
​https://bugs.webkit.org/show_bug.cgi?id=200090

Reviewed by Aakash Jain.

• resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
• resultsdbpy/resultsdbpy/view/view_routes.py:

(ViewRoutes.init): Make search the landing page instead of suite results.

• resultsdbpy/resultsdbpy/view/view_routes_unittest.py:

(WebSiteUnittest.test_main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/templates/suite_results.html (modified) (2 diffs)
• resultsdbpy/resultsdbpy/view/view_routes.py (modified) (3 diffs)
• resultsdbpy/resultsdbpy/view/view_routes_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-07-26  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Suite results shouldn't be the landing page
+        https://bugs.webkit.org/show_bug.cgi?id=200090
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
+        * resultsdbpy/resultsdbpy/view/view_routes.py:
+        (ViewRoutes.__init__): Make search the landing page instead of suite results.
+        * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
+        (WebSiteUnittest.test_main):
+
 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/templates/suite_results.html

@@ -36 +36 @@
 import {Drawer, BranchSelector, ConfigurationSelectors, LimitSlider} from '/assets/js/drawer.js';
 import {DOM, REF} from '/library/js/Ref.js';
-import {SearchBar} from '/assets/js/search.js';
 import {Legend, Timeline} from '/assets/js/timeline.js';
 
@@ -164 +163 @@
     ConfigurationSelectors(() => {view.reload()}),
 ])}
-${SearchBar(function () {
-    if (!arguments.length) {
-        console.error('No tests to search for');
-        return;
-    }
-    let params = queryToParams(document.URL.split('?')[1]);
-    params.suite = [];
-    params.test = [];
-
-    for (let i = 0; i < arguments.length; i++) {
-        params.suite.push(arguments[i].suite);
-        params.test.push(arguments[i].test);
-    }
-    window.location.assign("search?" + paramsToQuery(params));
-}, SUITES)}
 ${view}
 `);

trunk/Tools/resultsdbpy/resultsdbpy/view/view_routes.py

@@ -70 +70 @@
         )
 
-        self.add_url_rule('/', 'main', self.suites.results, methods=('GET',))
+        self.add_url_rule('/', 'main', self.suites.search, methods=('GET',))
 
         self.add_url_rule('/documentation', 'documentation', self.documentation, methods=('GET',))
@@ -79 +79 @@
         self.add_url_rule('/commit/next', 'commit_next', self.commits.next, methods=('GET',))
         self.add_url_rule('/commits', 'commits', self.commits.commits, methods=('GET',))
-        self.add_url_rule('/search', 'search', self.suites.search, methods=('GET',))
+        self.add_url_rule('/suites', 'suites', self.suites.results, methods=('GET',))
 
         self.add_url_rule('/urls/queue', 'urls-queue', self.ci.queue, methods=('GET',))
@@ -86 +86 @@
 
         self.site_menu.add_endpoint('Main', self.name + '.main')
-        self.site_menu.add_endpoint('Search', self.name + '.search')
+        self.site_menu.add_endpoint('Suites', self.name + '.suites')
         self.site_menu.add_endpoint('Documentation', self.name + '.documentation')
         self.site_menu.add_endpoint('Commits', self.name + '.commits')

trunk/Tools/resultsdbpy/resultsdbpy/view/view_routes_unittest.py

@@ -110 +110 @@
         driver.get(self.URL)
         content = driver.find_element_by_id('app').find_element_by_class_name('content')
-        self.assertIn('Not Found', content.text)
-        self.assertIn('No suites matching the specified criteria', content.text)
+        self.assertIsNotNone(content)
 
     @WaitForDockerTestCase.mock_if_no_docker(mock_redis=FakeStrictRedis, mock_cassandra=MockCassandraContext)