Changeset 248117 in webkit

Timestamp:

Aug 1, 2019 12:43:02 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

results.webkit.org: Collision detection for dots is off by 2 * dotMargin
​https://bugs.webkit.org/show_bug.cgi?id=200347

Patch by Zhifei Fang <​zhifei_fang@apple.com> on 2019-08-01
Reviewed by Jonathan Bedard.

• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:

(Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
+
+        results.webkit.org: Collision detection for dots is off by 2 * dotMargin
+        https://bugs.webkit.org/show_bug.cgi?id=200347
+
+        Reviewed by Jonathan Bedard.
+
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
+
 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js

@@ -323 +323 @@
             if (currentDotIndex < dots.length && comp(scales[i], getScale(dots[currentDotIndex])) === 0) {
                 render(dots[currentDotIndex], context, x, radius);
-                dots[currentDotIndex]._dotCenter = {x: x + 3 * radius, y: radius};
+                dots[currentDotIndex]._dotCenter = {x: x + dotMargin + radius, y: radius};
                 dots[currentDotIndex]._cachedScrollLeft = scrollLeft < padding ? scrollLeft : scrollLeft - padding;
                 inCacheDots.push(dots[currentDotIndex]);