Changeset 248146 in webkit

Timestamp:

Aug 1, 2019 8:50:15 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

results.webkit.org: Force update cache when timeline updated
​https://bugs.webkit.org/show_bug.cgi?id=200363

Patch by Zhifei Fang <​zhifei_fang@apple.com> on 2019-08-01
Reviewed by Jonathan Bedard.

• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:

(offscreenCachedRenderFactory): Add ability to force the redraw.
(Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
(Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (modified) (5 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
+
+        results.webkit.org: Force update cache when timeline updated
+        https://bugs.webkit.org/show_bug.cgi?id=200363
+
+        Reviewed by Jonathan Bedard.
+
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (offscreenCachedRenderFactory): Add ability to force the redraw.
+        (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
+        (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
+
 2019-08-01  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js

@@ -132 +132 @@
     // and copy the viewport area from of it
     // It will trigger redrawCache when cache don't have enough space
-    return (redrawCache, element, stateDiff, state) => {
+    return (redrawCache, element, stateDiff, state, forceRedrawCache = false) => {
         const width = typeof stateDiff.width === 'number' ? stateDiff.width : state.width;
         if (width <= 0)
@@ -142 +142 @@
         const context = element.getContext('2d');
         let cachePosLeft = scrollLeft - cachedScrollLeft;
+        let needToRedrawCache = forceRedrawCache;
 
         if (element.logicWidth != width) {
             // Setup the dpr in case of blur
             setupCanvasWidthWithDpr(element, width);
-
-            // We draw everything on cache
-            redrawCache(offscreenCanvas, element, stateDiff, state, () => {
-                cachedScrollLeft = scrollLeft < padding ? scrollLeft : scrollLeft - padding;
-                cachePosLeft = scrollLeft - cachedScrollLeft;
-                if (cachePosLeft < 0)
-                    cachePosLeft = 0;
-                context.clearRect(0, 0, element.width, element.height);
-                context.drawImage(offscreenCanvas, cachePosLeft * getDevicePixelRatio(), 0,    element.width, element.height, 0, 0, width * getDevicePixelRatio(), element.height);
-            });
-
+            needToRedrawCache = true;
         } else if (cachePosLeft < 0 || cachePosLeft + width > totalWidth) {
             if (scrollLeft < 0 )
                 return;
-            redrawCache(offscreenCanvas, element, stateDiff, state,    () => {
+            needToRedrawCache = true;
+        }
+
+        if (needToRedrawCache) {
+            // We draw everything on cache
+            redrawCache(offscreenCanvas, element, stateDiff, state, () => {
                 cachedScrollLeft = scrollLeft < padding ? scrollLeft : scrollLeft - padding;
                 cachePosLeft = scrollLeft - cachedScrollLeft;
@@ -368 +364 @@
         onStateUpdate: (element, stateDiff, state) => {
             const context = element.getContext("2d");
+            let forceRedrawCache = false;
             if (stateDiff.scales || stateDiff.dots || typeof stateDiff.scrollLeft === 'number' || typeof stateDiff.width === 'number') {
                 console.assert(dots.length <= scales.length);
-                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state));
+                if (stateDiff.scales || stateDiff.dots) {
+                    forceRedrawCache = true;
+                }
+                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state, forceRedrawCache));
             }
         }
@@ -712 +712 @@
         },
         onStateUpdate: (element, stateDiff, state) => {
+            let forceRedrawCache = false;
             if (stateDiff.scales || typeof stateDiff.scrollLeft === 'number' || typeof stateDiff.width === 'number') {
-                if (stateDiff.scales)
+                if (stateDiff.scales) {
                     state.scalesMapLinkList = getScalesMapLinkList(stateDiff.scales);
-                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state));
+                    forceRedrawCache = true;
+                }
+                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state, forceRedrawCache));
             }
         }
@@ -723 +726 @@
         series: ListProviderReceiver((updateContainerWidth, onContainerScroll, onResize) => {
             updateContainerWidth(scales.length * scaleWidth * getDevicePixelRatio());
+            const updateData = (scales) => {
+                updateContainerWidth(scales.length * scaleWidth * getDevicePixelRatio());
+                canvasRef.setState({
+                    scales: scales
+                });
+            }
+            if (typeof option.exporter === "function")
+                option.exporter(updateData);
             onContainerScroll.action((e) => {
                 canvasRef.setState({scrollLeft: e.target.scrollLeft / getDevicePixelRatio()});