Changeset 248167 in webkit


Ignore:
Timestamp:
Aug 2, 2019 11:58:46 AM (5 years ago)
Author:
eric.carlson@apple.com
Message:

[macOS, iOS] webaudio/silent-audio-interrupted-in-background.html sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=200396
<rdar://problem/53819720>

Reviewed by Youenn Fablet.

No new test, this fixes an existing test.

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC): Drop the
lock before clearing m_tapStorage.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r248161 r248167  
     12019-08-02  Eric Carlson  <eric.carlson@apple.com>
     2
     3        [macOS, iOS] webaudio/silent-audio-interrupted-in-background.html sometimes crashes
     4        https://bugs.webkit.org/show_bug.cgi?id=200396
     5        <rdar://problem/53819720>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        No new test, this fixes an existing test.
     10
     11        * platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
     12        (WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC): Drop the
     13        lock before clearing m_tapStorage.
     14
    1152019-08-02  Youenn Fablet  <youenn@apple.com>
    216
  • trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm

    r247701 r248167  
    9191        std::lock_guard<Lock> lock(m_tapStorage->mutex);
    9292        m_tapStorage->_this = nullptr;
    93         m_tapStorage = nullptr;
    94     }
     93    }
     94
     95    m_tapStorage = nullptr;
    9596}
    9697
Note: See TracChangeset for help on using the changeset viewer.