Changeset 248295 in webkit


Ignore:
Timestamp:
Aug 6, 2019 8:37:28 AM (5 years ago)
Author:
Antti Koivisto
Message:

REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
https://bugs.webkit.org/show_bug.cgi?id=200466

Reviewed by Zalan Bujtas.

The page calls preventDefault() for a mouse event generated by a site specific quirk.

  • page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r248292 r248295  
     12019-08-06  Antti Koivisto  <antti@apple.com>
     2
     3        REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
     4        https://bugs.webkit.org/show_bug.cgi?id=200466
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        The page calls preventDefault() for a mouse event generated by a site specific quirk.
     9
     10        * page/Quirks.cpp:
     11        (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
     12
     13        Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.
     14
    1152019-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
    216
  • trunk/Source/WebCore/page/Quirks.cpp

    r248079 r248295  
    296296    if (equalLettersIgnoringASCIICase(host, "naver.com"))
    297297        return true;
    298     // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
    299     if (host.endsWithIgnoringASCIICase(".naver.com"))
    300         return !equalLettersIgnoringASCIICase(host, "tv.naver.com");
     298    if (host.endsWithIgnoringASCIICase(".naver.com")) {
     299        // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
     300        if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
     301            return false;
     302        // Disable the quirk on the mobile site.
     303        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
     304        if (equalLettersIgnoringASCIICase(host, "m.naver.com"))
     305            return false;
     306        return true;
     307    }
    301308    return false;
    302309}
Note: See TracChangeset for help on using the changeset viewer.