Changeset 248370 in webkit


Ignore:
Timestamp:
Aug 7, 2019 10:17:05 AM (5 years ago)
Author:
Wenson Hsieh
Message:

Declarations and implementations of findCaret(Min|Max)imumOffset have inconsistent signatures
https://bugs.webkit.org/show_bug.cgi?id=200503

Reviewed by Darin Adler.

No change in behavior.

  • rendering/SimpleLineLayoutFunctions.h:

Update these function declarations to take "const RenderText&", which matches the signatures of their inline
implementations below.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r248368 r248370  
     12019-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Declarations and implementations of findCaret(Min|Max)imumOffset have inconsistent signatures
     4        https://bugs.webkit.org/show_bug.cgi?id=200503
     5
     6        Reviewed by Darin Adler.
     7
     8        No change in behavior.
     9
     10        * rendering/SimpleLineLayoutFunctions.h:
     11
     12        Update these function declarations to take "const RenderText&", which matches the signatures of their inline
     13        implementations below.
     14
    1152019-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
    216
  • trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.h

    r248368 r248370  
    5353enum class OffsetType { CaretOffset, CharacterOffset };
    5454bool containsOffset(const RenderText&, const Layout&, unsigned, OffsetType);
    55 unsigned findCaretMinimumOffset(const RenderObject&, const Layout&);
    56 unsigned findCaretMaximumOffset(const RenderObject&, const Layout&);
     55unsigned findCaretMinimumOffset(const RenderText&, const Layout&);
     56unsigned findCaretMaximumOffset(const RenderText&, const Layout&);
    5757IntRect computeBoundingBox(const RenderObject&, const Layout&);
    5858IntPoint computeFirstRunLocation(const RenderObject&, const Layout&);
Note: See TracChangeset for help on using the changeset viewer.