Changeset 248389 in webkit


Ignore:
Timestamp:
Aug 7, 2019 2:17:36 PM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Uncaught Exception: TimelineAgent already enabled
https://bugs.webkit.org/show_bug.cgi?id=200513

Reviewed by Joseph Pecoraro.

Source/WebCore:

Call disable when the last frontend disconnects, so that if Web Inspector is reopened the
TimelineAgent is back to being in a disabled state.

  • inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):

Source/WebInspectorUI:

Update some incorrect compatibility comments from r248286.

  • UserInterface/Protocol/InspectorFrontendAPI.js:
  • UserInterface/Controllers/TimelineManager.js:
Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r248387 r248389  
     12019-08-07  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Uncaught Exception: TimelineAgent already enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=200513
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Call `disable` when the last frontend disconnects, so that if Web Inspector is reopened the
     9        `TimelineAgent` is back to being in a disabled state.
     10
     11        * inspector/agents/InspectorTimelineAgent.cpp:
     12        (WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
     13
    1142019-08-07  Jer Noble  <jer.noble@apple.com>
    215
  • trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp

    r248286 r248389  
    101101void InspectorTimelineAgent::willDestroyFrontendAndBackend(Inspector::DisconnectReason)
    102102{
     103    ErrorString ignored;
     104    disable(ignored);
    103105}
    104106
  • trunk/Source/WebInspectorUI/ChangeLog

    r248328 r248389  
     12019-08-07  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Uncaught Exception: TimelineAgent already enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=200513
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Update some incorrect compatibility comments from r248286.
     9
     10        * UserInterface/Protocol/InspectorFrontendAPI.js:
     11        * UserInterface/Controllers/TimelineManager.js:
     12
    1132019-08-06  Devin Rousso  <drousso@apple.com>
    214
  • trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js

    r248286 r248389  
    8484
    8585        if (target.TimelineAgent) {
    86             // COMPATIBILITY (iOS 13.1): Timeline.enable did not exist.
     86            // COMPATIBILITY (iOS 13): Timeline.enable did not exist yet.
    8787            if (target.TimelineAgent.enable)
    8888                target.TimelineAgent.enable();
     
    282282
    283283        for (let target of WI.targets) {
    284             // COMPATIBILITY (iOS 13.1): Timeline.disable did not exist.
     284            // COMPATIBILITY (iOS 13): Timeline.disable did not exist yet.
    285285            if (target.TimelineAgent && target.TimelineAgent.disable)
    286286                target.TimelineAgent.disable();
  • trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js

    r248177 r248389  
    109109    },
    110110
    111     // COMPATIBILITY (iOS 13.1): merged into InspectorFrontendAPI.setTimelineProfilingEnabled.
     111    // COMPATIBILITY (iOS 13): merged into InspectorFrontendAPI.setTimelineProfilingEnabled.
    112112    showTimelines: function()
    113113    {
Note: See TracChangeset for help on using the changeset viewer.