Changeset 248389 in webkit
- Timestamp:
- Aug 7, 2019 2:17:36 PM (5 years ago)
- Location:
- trunk/Source
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r248387 r248389 1 2019-08-07 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Uncaught Exception: TimelineAgent already enabled 4 https://bugs.webkit.org/show_bug.cgi?id=200513 5 6 Reviewed by Joseph Pecoraro. 7 8 Call `disable` when the last frontend disconnects, so that if Web Inspector is reopened the 9 `TimelineAgent` is back to being in a disabled state. 10 11 * inspector/agents/InspectorTimelineAgent.cpp: 12 (WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend): 13 1 14 2019-08-07 Jer Noble <jer.noble@apple.com> 2 15 -
trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp
r248286 r248389 101 101 void InspectorTimelineAgent::willDestroyFrontendAndBackend(Inspector::DisconnectReason) 102 102 { 103 ErrorString ignored; 104 disable(ignored); 103 105 } 104 106 -
trunk/Source/WebInspectorUI/ChangeLog
r248328 r248389 1 2019-08-07 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Uncaught Exception: TimelineAgent already enabled 4 https://bugs.webkit.org/show_bug.cgi?id=200513 5 6 Reviewed by Joseph Pecoraro. 7 8 Update some incorrect compatibility comments from r248286. 9 10 * UserInterface/Protocol/InspectorFrontendAPI.js: 11 * UserInterface/Controllers/TimelineManager.js: 12 1 13 2019-08-06 Devin Rousso <drousso@apple.com> 2 14 -
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
r248286 r248389 84 84 85 85 if (target.TimelineAgent) { 86 // COMPATIBILITY (iOS 13 .1): Timeline.enable did not exist.86 // COMPATIBILITY (iOS 13): Timeline.enable did not exist yet. 87 87 if (target.TimelineAgent.enable) 88 88 target.TimelineAgent.enable(); … … 282 282 283 283 for (let target of WI.targets) { 284 // COMPATIBILITY (iOS 13 .1): Timeline.disable did not exist.284 // COMPATIBILITY (iOS 13): Timeline.disable did not exist yet. 285 285 if (target.TimelineAgent && target.TimelineAgent.disable) 286 286 target.TimelineAgent.disable(); -
trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js
r248177 r248389 109 109 }, 110 110 111 // COMPATIBILITY (iOS 13 .1): merged into InspectorFrontendAPI.setTimelineProfilingEnabled.111 // COMPATIBILITY (iOS 13): merged into InspectorFrontendAPI.setTimelineProfilingEnabled. 112 112 showTimelines: function() 113 113 {
Note: See TracChangeset
for help on using the changeset viewer.