Changeset 248392 in webkit


Ignore:
Timestamp:
Aug 7, 2019 2:51:16 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

LayoutTest inspector/worker/debugger-scripts.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=165582

Patch by Yury Semikhatsky <​yurys@chromium.org> on 2019-08-07
Reviewed by Joseph Pecoraro.

Unflake the test. Main resource in the worker target is populated asychronously
when the script is parsed and sent to the debugger, so we need to wait for it
before performing further checks.

  • inspector/worker/debugger-scripts.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r248388 r248392  
     12019-08-07  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        LayoutTest inspector/worker/debugger-scripts.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=165582
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Unflake the test. Main resource in the worker target is populated asychronously
     9        when the script is parsed and sent to the debugger, so we need to wait for it
     10        before performing further checks.
     11
     12        * inspector/worker/debugger-scripts.html:
     13        * platform/mac/TestExpectations:
     14
    1152019-08-07  Russell Epstein  <repstein@apple.com>
    216

  • trunk/LayoutTests/inspector/worker/debugger-scripts.html

    r225892 r248392  
    33<head>
    44<script src="../../http/tests/inspector/resources/inspector-test.js"></script>
     5<script src="resources/worker-utilities.js"></script>
    56<script>
    67let worker = new Worker("resources/worker-scripts.js");
    … …  
    9091    });
    9192
    92     suite.runTestCasesAndFinish();
     93    awaitTargetMainResource(workerTarget).then(() => suite.runTestCasesAndFinish());
    9394}
    9495</script>

  • trunk/LayoutTests/platform/mac/TestExpectations

    r248111 r248392  
    10871087webkit.org/b/169228 inspector/worker/console-basic.html [ Pass Timeout ]
    10881088webkit.org/b/164872 inspector/worker/debugger-multiple-targets-pause.html [ Pass Failure Timeout ]
    1089 webkit.org/b/165582 inspector/worker/debugger-scripts.html [ Pass Failure ]
    10901089webkit.org/b/167203 inspector/worker/debugger-shared-breakpoint.html [ Pass Failure Timeout ]
    10911090webkit.org/b/155607 inspector/heap/imported-snapshot.html [ Pass Failure ]
Note: See TracChangeset for help on using the changeset viewer.