Changeset 248394 in webkit

Timestamp:

Aug 7, 2019 4:36:27 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Remove speculative workaround for upload crash
​https://bugs.webkit.org/show_bug.cgi?id=200514

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-08-07
Reviewed by Geoffrey Garen.

This workaround didn't help anyways, and the crash has been resolved. Let's clean up.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cocoa/NetworkSessionCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-07  Alex Christensen  <achristensen@webkit.org>
+
+        Remove speculative workaround for upload crash
+        https://bugs.webkit.org/show_bug.cgi?id=200514
+
+        Reviewed by Geoffrey Garen.
+
+        This workaround didn't help anyways, and the crash has been resolved.  Let's clean up.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):
+
 2019-08-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

@@ -395 +395 @@
     }
 
-    // FIXME: Call the completionHandler immediately once rdar://problem/28233746 is fixed.
-    RunLoop::main().dispatch([body = makeRef(*body), completionHandler = makeBlockPtr(completionHandler)] {
-        completionHandler(WebCore::createHTTPBodyNSInputStream(body.get()).get());
-    });
+    completionHandler(WebCore::createHTTPBodyNSInputStream(*body).get());
 }