Changeset 248404 in webkit


Ignore:
Timestamp:
Aug 8, 2019 1:20:41 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Import lazy loading WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=199795

Patch by Rob Buis <​rbuis@igalia.com> on 2019-08-08
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import lazy loading WPT tests.

  • resources/import-expectations.json:
  • web-platform-tests/loading/lazyload/iframe-loading-eager.tentative-expected.txt: Added.
  • web-platform-tests/loading/lazyload/iframe-loading-eager.tentative.html: Added.
  • web-platform-tests/loading/lazyload/iframe-loading-lazy.tentative.html: Added.
  • web-platform-tests/loading/lazyload/image-loading-eager.tentative-expected.txt: Added.
  • web-platform-tests/loading/lazyload/image-loading-eager.tentative.html: Added.
  • web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html: Added.
  • web-platform-tests/loading/lazyload/resources/image.png: Added.
  • web-platform-tests/loading/lazyload/resources/subframe.html: Added.
  • web-platform-tests/loading/lazyload/resources/w3c-import.log: Added.
  • web-platform-tests/loading/lazyload/w3c-import.log: Added.

Tools:

Only do loading/ exception for WebKit specific, non WPT tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(shouldLogFrameLoadDelegates):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):

LayoutTests:

Skip the lazy tests for now.

Location:
trunk
Files:
13 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r248392 r248404  
     12019-08-08  Rob Buis  <rbuis@igalia.com>
     2
     3        Import lazy loading WPT tests
     4        https://bugs.webkit.org/show_bug.cgi?id=199795
     5
     6        Reviewed by Darin Adler.
     7
     8        Skip the lazy tests for now.
     9
     10        * TestExpectations:
     11        * http/wpt/loading/redirect-headers-expected.txt:
     12
    1132019-08-07  Yury Semikhatsky  <yurys@chromium.org>
    214

  • trunk/LayoutTests/TestExpectations

    r248102 r248404  
    34653465fast/text/design-system-ui-15.html [ ImageOnlyFailure ]
    34663466fast/text/design-system-ui-16.html [ ImageOnlyFailure ]
     3467
     3468webkit.org/b/196698 imported/w3c/web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html
     3469webkit.org/b/196698 imported/w3c/web-platform-tests/loading/lazyload/iframe-loading-lazy.tentative.html

  • trunk/LayoutTests/http/wpt/loading/redirect-headers-expected.txt

    r230224 r248404  
    1 main frame - didStartProvisionalLoadForFrame
    2 main frame - didCommitLoadForFrame
    3 main frame - didFinishDocumentLoadForFrame
    41http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - willSendRequest <NSURLRequest URL http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/, main document URL http://localhost:8800/WebKit/loading/redirect-headers.html, http method GET> redirectResponse (null)
    5 main frame - didHandleOnloadEventsForFrame
    6 main frame - didFinishLoadForFrame
    72http://localhost:8800/WebKit/loading/redirect-headers.html - didFinishLoading
    83http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - willSendRequest <NSURLRequest URL http://localhost:8800/?status=302&location=%2F&count=1, main document URL http://localhost:8800/WebKit/loading/redirect-headers.html, http method GET> redirectResponse <NSURLResponse http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/, http status code 302, 6 headers>

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r248283 r248404  
     12019-08-08  Rob Buis  <rbuis@igalia.com>
     2
     3        Import lazy loading WPT tests
     4        https://bugs.webkit.org/show_bug.cgi?id=199795
     5
     6        Reviewed by Darin Adler.
     7
     8        Import lazy loading WPT tests.
     9
     10        * resources/import-expectations.json:
     11        * web-platform-tests/loading/lazyload/iframe-loading-eager.tentative-expected.txt: Added.
     12        * web-platform-tests/loading/lazyload/iframe-loading-eager.tentative.html: Added.
     13        * web-platform-tests/loading/lazyload/iframe-loading-lazy.tentative.html: Added.
     14        * web-platform-tests/loading/lazyload/image-loading-eager.tentative-expected.txt: Added.
     15        * web-platform-tests/loading/lazyload/image-loading-eager.tentative.html: Added.
     16        * web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html: Added.
     17        * web-platform-tests/loading/lazyload/resources/image.png: Added.
     18        * web-platform-tests/loading/lazyload/resources/subframe.html: Added.
     19        * web-platform-tests/loading/lazyload/resources/w3c-import.log: Added.
     20        * web-platform-tests/loading/lazyload/w3c-import.log: Added.
     21
    1222019-08-05  Youenn Fablet  <youenn@apple.com>
    223

  • trunk/LayoutTests/imported/w3c/resources/import-expectations.json

    r247457 r248404  
    262262    "web-platform-tests/js": "skip",
    263263    "web-platform-tests/keyboard-lock": "skip",
     264    "web-platform-tests/loading/lazyload": "import",
    264265    "web-platform-tests/longtask-timing": "skip",
    265266    "web-platform-tests/magnetometer": "skip",

  • trunk/Tools/ChangeLog

    r248399 r248404  
     12019-08-08  Rob Buis  <rbuis@igalia.com>
     2
     3        Import lazy loading WPT tests
     4        https://bugs.webkit.org/show_bug.cgi?id=199795
     5
     6        Reviewed by Darin Adler.
     7
     8        Only do loading/ exception for WebKit specific, non WPT tests.
     9
     10        * DumpRenderTree/mac/DumpRenderTree.mm:
     11        (shouldLogFrameLoadDelegates):
     12        * WebKitTestRunner/TestInvocation.cpp:
     13        (WTR::TestInvocation::TestInvocation):
     14
    1152019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
    216

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r247692 r248404  
    18031803static bool shouldLogFrameLoadDelegates(const char* pathOrURL)
    18041804{
    1805     return strstr(pathOrURL, "loading/");
     1805    return strstr(pathOrURL, "loading/") && !strstr(pathOrURL, "://localhost");
    18061806}
    18071807

  • trunk/Tools/WebKitTestRunner/TestInvocation.cpp

    r247941 r248404  
    8484
    8585    // FIXME: Avoid mutating the setting via a test directory like this.
    86     m_dumpFrameLoadCallbacks = urlContains("loading/");
     86    m_dumpFrameLoadCallbacks = urlContains("loading/") && !urlContains("://localhost");
    8787}
    8888
Note: See TracChangeset for help on using the changeset viewer.