Changeset 248471 in webkit
- Timestamp:
- Aug 9, 2019 1:20:49 PM (5 years ago)
- Location:
- trunk/Source
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r248467 r248471 1 2019-08-09 Alex Christensen <achristensen@webkit.org> 2 3 Disable CSSOM View Scrolling API for IMDb iOS app 4 https://bugs.webkit.org/show_bug.cgi?id=200586 5 <rdar://problem/53645833> 6 7 Reviewed by Simon Fraser. 8 9 They are calling scrollHeight on the HTML element and it is running new code introduced in r235806 10 Disable this new feature until they update their app to use the iOS13 SDK. 11 12 * platform/RuntimeApplicationChecks.h: 13 * platform/cocoa/RuntimeApplicationChecksCocoa.mm: 14 (WebCore::IOSApplication::isIMDb): 15 1 16 2019-08-09 Youenn Fablet <youenn@apple.com> 2 17 -
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
r246664 r248471 44 44 45 45 WEBCORE_EXPORT void setApplicationSDKVersion(uint32_t); 46 uint32_t applicationSDKVersion();46 WEBCORE_EXPORT uint32_t applicationSDKVersion(); 47 47 48 48 WEBCORE_EXPORT void setApplicationBundleIdentifier(const String&); … … 79 79 WEBCORE_EXPORT bool isMobileMail(); 80 80 WEBCORE_EXPORT bool isMobileSafari(); 81 WEBCORE_EXPORT bool isIMDb(); 81 82 WEBCORE_EXPORT bool isWebBookmarksD(); 82 83 WEBCORE_EXPORT bool isDumpRenderTree(); -
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
r246664 r248471 209 209 } 210 210 211 bool IOSApplication::isIMDb() 212 { 213 static bool isIMDb = applicationBundleIsEqualTo("com.imdb.imdb"_s); 214 return isIMDb; 215 } 216 211 217 bool IOSApplication::isWebBookmarksD() 212 218 { -
trunk/Source/WebKit/ChangeLog
r248469 r248471 1 2019-08-09 Alex Christensen <achristensen@webkit.org> 2 3 Disable CSSOM View Scrolling API for IMDb iOS app 4 https://bugs.webkit.org/show_bug.cgi?id=200586 5 <rdar://problem/53645833> 6 7 Reviewed by Simon Fraser. 8 9 Change the CSSOMViewScrollingAPIEnabled default value to be off for the IMDb app's WKWebViews. 10 I manually verified this is effective in those WKWebViews but no other WKWebViews and that it fixes the radar. 11 12 * Shared/WebPreferences.yaml: 13 * Shared/WebPreferencesDefaultValues.cpp: 14 (WebKit::defaultCSSOMViewScrollingAPIEnabled): 15 * Shared/WebPreferencesDefaultValues.h: 16 1 17 2019-08-09 Tim Horton <timothy_horton@apple.com> 2 18 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r248409 r248471 1285 1285 CSSOMViewScrollingAPIEnabled: 1286 1286 type: bool 1287 defaultValue: true1287 defaultValue: defaultCSSOMViewScrollingAPIEnabled() 1288 1288 humanReadableName: "CSSOM View Scrolling API" 1289 1289 humanReadableDescription: "Implement standard behavior for scrollLeft, scrollTop, scrollWidth, scrollHeight, scrollTo, scrollBy and scrollingElement." -
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
r246892 r248471 62 62 } 63 63 64 bool defaultCSSOMViewScrollingAPIEnabled() 65 { 66 #if PLATFORM(IOS_FAMILY) 67 if (WebCore::IOSApplication::isIMDb() && applicationSDKVersion() < DYLD_IOS_VERSION_13_0) 68 return false; 69 #endif 70 return true; 71 } 72 64 73 #if ENABLE(TEXT_AUTOSIZING) && !PLATFORM(IOS_FAMILY) 65 74 -
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
r246148 r248471 281 281 bool defaultPassiveTouchListenersAsDefaultOnDocument(); 282 282 bool defaultCustomPasteboardDataEnabled(); 283 bool defaultCSSOMViewScrollingAPIEnabled(); 283 284 284 285 #if ENABLE(TEXT_AUTOSIZING)
Note: See TracChangeset
for help on using the changeset viewer.