Changeset 248521 in webkit

Timestamp:

Aug 11, 2019 9:21:25 AM (5 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] Don't use vorbisparse
​https://bugs.webkit.org/show_bug.cgi?id=200622

Reviewed by Philippe Normand.

Source/WebCore:

This patch has been splitted from the original WebKitMediaSrc rework
patch (​https://bugs.webkit.org/show_bug.cgi?id=199719).

Unlike other parsers, vorbisparse has latency (in the sense that when
it gets a chain call with a series of complete frames, it may not emit
the parsed frames until another chain in the future), which makes it
inappropriate for AppendPipeline, as there is no good way I know to
flush it.

But actually vorbisparse is not known to be necessary and it was only
introduced for consistency with other formats. Parsers are used in
AppendPipeline to reconstruct information that is lost due to poor
muxes. There have been no reported cases of this being a problem with
Vorbis in WebM, so I'm just removing the parser.

Fixes imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::createOptionalParserForFormat):

LayoutTests:

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-11  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Don't use vorbisparse
+        https://bugs.webkit.org/show_bug.cgi?id=200622
+
+        Reviewed by Philippe Normand.
+
+        * platform/gtk/TestExpectations:
+
 2019-08-10  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -229 +229 @@
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Failure Crash ]
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Failure ]
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html [ Failure ]
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-framesize.html [ Failure Pass ]
 # Crash is webkit.org/b/176020

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-11  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Don't use vorbisparse
+        https://bugs.webkit.org/show_bug.cgi?id=200622
+
+        Reviewed by Philippe Normand.
+
+        This patch has been splitted from the original WebKitMediaSrc rework
+        patch (https://bugs.webkit.org/show_bug.cgi?id=199719).
+
+        Unlike other parsers, vorbisparse has latency (in the sense that when
+        it gets a chain call with a series of complete frames, it may not emit
+        the parsed frames until another chain in the future), which makes it
+        inappropriate for AppendPipeline, as there is no good way I know to
+        flush it.
+
+        But actually vorbisparse is not known to be necessary and it was only
+        introduced for consistency with other formats. Parsers are used in
+        AppendPipeline to reconstruct information that is lost due to poor
+        muxes. There have been no reported cases of this being a problem with
+        Vorbis in WebM, so I'm just removing the parser.
+
+        Fixes imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html
+
+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+        (WebCore::createOptionalParserForFormat):
+
 2019-08-11  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

@@ -646 +646 @@
         return GRefPtr<GstElement>(opusparse);
     }
-    if (!g_strcmp0(mediaType, "audio/x-vorbis")) {
-        GstElement* vorbisparse = gst_element_factory_make("vorbisparse", parserName.get());
-        ASSERT(vorbisparse);
-        g_return_val_if_fail(vorbisparse, nullptr);
-        return GRefPtr<GstElement>(vorbisparse);
-    }
     if (!g_strcmp0(mediaType, "video/x-h264")) {
         GstElement* h264parse = gst_element_factory_make("h264parse", parserName.get());