Changeset 248542 in webkit


Ignore:
Timestamp:
Aug 12, 2019 12:33:53 PM (5 years ago)
Author:
sihui_liu@apple.com
Message:

Remove an assertion in ~StorageArea()
https://bugs.webkit.org/show_bug.cgi?id=200630
<rdar://problem/54097722>

Reviewed by Chris Dumez.

In r247370, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to
make sure StorageArea gets destroyed on the background thread.
StorageArea can get destroyed before LocalStorageNamespace, so the assertion in ~StorageArea() is not true any
more.

  • NetworkProcess/WebStorage/StorageArea.cpp:

(WebKit::StorageArea::~StorageArea):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r248541 r248542  
     12019-08-12  Sihui Liu  <sihui_liu@apple.com>
     2
     3        Remove an assertion in ~StorageArea()
     4        https://bugs.webkit.org/show_bug.cgi?id=200630
     5        <rdar://problem/54097722>
     6
     7        Reviewed by Chris Dumez.
     8
     9        In r247370, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to
     10        make sure StorageArea gets destroyed on the background thread.
     11        StorageArea can get destroyed before LocalStorageNamespace, so the assertion in ~StorageArea() is not true any
     12        more.
     13
     14        * NetworkProcess/WebStorage/StorageArea.cpp:
     15        (WebKit::StorageArea::~StorageArea):
     16
    1172019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
    218
  • trunk/Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp

    r248452 r248542  
    5050    ASSERT(!RunLoop::isMain());
    5151    ASSERT(m_eventListeners.isEmpty());
    52     ASSERT(!m_localStorageNamespace);
    5352
    5453    if (m_localStorageDatabase)
Note: See TracChangeset for help on using the changeset viewer.