Changeset 248547 in webkit


Ignore:
Timestamp:
Aug 12, 2019 2:37:16 PM (5 years ago)
Author:
Adrian Perez de Castro
Message:

[WPE][GTK] Fix building without unified sources
https://bugs.webkit.org/show_bug.cgi?id=200641

Reviewed by Žan Doberšek.

Source/JavaScriptCore:

  • b3/B3PatchpointSpecial.cpp: Add missing inclusion of the B3ProcedureInlines.h header.
  • heap/SlotVisitor.cpp: Add missing inclusion of the BlockDirectoryInlines.h header.

Source/WebCore:

  • CMakeLists.txt: Add WebCore as the list of libraries to link into WebCoreTestSupport, to

avoid underlinking, which makes it possible to link with LDFLAGS="-Wl,--no-undefined".

  • editing/WebCorePasteboardFileReader.h: Add missing inclusion of the pal/SessionID.h

header.

Source/WebKit:

  • UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp: Add missing inclusions for headers

WebCore/GtkUtilities.h (for convertWidgetPointToScreenPoint), WebCore/IntPoint.h, and
WebPageProxy.h (the two latter to avoid usage of undefined types).
(WebKit::WebDataListSuggestionsDropdownGtk::show): Add namespace prefix to use
WebCore::IntPoint.

Location:
trunk/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r248546 r248547  
     12019-08-12  Adrian Perez de Castro  <aperez@igalia.com>
     2
     3        [WPE][GTK] Fix building without unified sources
     4        https://bugs.webkit.org/show_bug.cgi?id=200641
     5
     6        Reviewed by Žan Doberšek.
     7
     8        * b3/B3PatchpointSpecial.cpp: Add missing inclusion of the B3ProcedureInlines.h header.
     9        * heap/SlotVisitor.cpp: Add missing inclusion of the BlockDirectoryInlines.h header.
     10
    1112019-08-12  Yusuke Suzuki  <ysuzuki@apple.com>
    212
  • trunk/Source/JavaScriptCore/b3/B3PatchpointSpecial.cpp

    r248178 r248547  
    3131#include "AirCode.h"
    3232#include "AirGenerationContext.h"
     33#include "B3ProcedureInlines.h"
    3334#include "B3StackmapGenerationParams.h"
    3435#include "B3ValueInlines.h"
  • trunk/Source/JavaScriptCore/heap/SlotVisitor.cpp

    r248143 r248547  
    2727#include "SlotVisitor.h"
    2828
     29#include "BlockDirectoryInlines.h"
    2930#include "CPU.h"
    3031#include "ConservativeRoots.h"
  • trunk/Source/WebCore/CMakeLists.txt

    r247527 r248547  
    12121212
    12131213set(WebCoreTestSupport_LIBRARIES
     1214    WebCore
    12141215    WebKit::JavaScriptCore
    12151216)
  • trunk/Source/WebCore/ChangeLog

    r248546 r248547  
     12019-08-12  Adrian Perez de Castro  <aperez@igalia.com>
     2
     3        [WPE][GTK] Fix building without unified sources
     4        https://bugs.webkit.org/show_bug.cgi?id=200641
     5
     6        Reviewed by Žan Doberšek.
     7
     8        * CMakeLists.txt: Add WebCore as the list of libraries to link into WebCoreTestSupport, to
     9        avoid underlinking, which makes it possible to link with LDFLAGS="-Wl,--no-undefined".
     10        * editing/WebCorePasteboardFileReader.h: Add missing inclusion of the pal/SessionID.h
     11        header.
     12
    1132019-08-12  Yusuke Suzuki  <ysuzuki@apple.com>
    214
  • trunk/Source/WebCore/editing/WebCorePasteboardFileReader.h

    r248503 r248547  
    2727
    2828#include "Pasteboard.h"
     29#include <pal/SessionID.h>
    2930
    3031namespace WebCore {
  • trunk/Source/WebKit/ChangeLog

    r248543 r248547  
     12019-08-12  Adrian Perez de Castro  <aperez@igalia.com>
     2
     3        [WPE][GTK] Fix building without unified sources
     4        https://bugs.webkit.org/show_bug.cgi?id=200641
     5
     6        Reviewed by Žan Doberšek.
     7
     8        * UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp: Add missing inclusions for headers
     9        WebCore/GtkUtilities.h (for convertWidgetPointToScreenPoint), WebCore/IntPoint.h, and
     10        WebPageProxy.h (the two latter to avoid usage of undefined types).
     11        (WebKit::WebDataListSuggestionsDropdownGtk::show): Add namespace prefix to use
     12        WebCore::IntPoint.
     13
    1142019-08-12  Sihui Liu  <sihui_liu@apple.com>
    215
  • trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp

    r248033 r248547  
    2929#if ENABLE(DATALIST_ELEMENT)
    3030
     31#include "WebPageProxy.h"
    3132#include <WebCore/DataListSuggestionInformation.h>
     33#include <WebCore/GtkUtilities.h>
     34#include <WebCore/IntPoint.h>
    3235#include <wtf/glib/GRefPtr.h>
    3336#include <wtf/glib/GUniquePtr.h>
     
    150153    GtkRequisition menuRequisition;
    151154    gtk_widget_get_preferred_size(m_popup, &menuRequisition, nullptr);
    152     IntPoint menuPosition = convertWidgetPointToScreenPoint(m_webView, information.elementRect.location());
     155    WebCore::IntPoint menuPosition = convertWidgetPointToScreenPoint(m_webView, information.elementRect.location());
    153156    // FIXME: We can't ensure the menu will be on screen in Wayland.
    154157    // https://blog.gtk.org/2016/07/15/future-of-relative-window-positioning/
Note: See TracChangeset for help on using the changeset viewer.