Changeset 248590 in webkit

Timestamp:

Aug 12, 2019 8:56:37 PM (5 years ago)

Author:

Devin Rousso

Message:

REGRESSION(r248391): Web Inspector: changing Layout Direction Debug setting no longer adds dir="ltr" to body element
​https://bugs.webkit.org/show_bug.cgi?id=200564

Reviewed by Joseph Pecoraro.

WI.resolvedLayoutDirection was called before WI.runBootstrapOperations, which is what
instantiates WI.showDebugUISetting. Without it, WI.resolvedLayoutDirection will ignore
the value of WI.settings.debugLayoutDirection and instead use the system.

Moving the instantiation of WI.showDebugUISetting outside WI.runBootstrapOperations
allows the setting to be created when the Bootstrap.js script is loaded, rather than after
the DOMContentLoaded event is fired. This means that it's guaranteed to exist before any
interface/view code runs.

• UserInterface/Debug/Bootstrap.js:

(WI.runBootstrapOperations):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Debug/Bootstrap.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-12  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION(r248391): Web Inspector: changing Layout Direction Debug setting no longer adds dir="ltr" to body element
+        https://bugs.webkit.org/show_bug.cgi?id=200564
+
+        Reviewed by Joseph Pecoraro.
+
+        `WI.resolvedLayoutDirection` was called before `WI.runBootstrapOperations`, which is what
+        instantiates `WI.showDebugUISetting`. Without it, `WI.resolvedLayoutDirection` will ignore
+        the value of `WI.settings.debugLayoutDirection` and instead use the system.
+
+        Moving the instantiation of `WI.showDebugUISetting` outside `WI.runBootstrapOperations`
+        allows the setting to be created when the Bootstrap.js script is loaded, rather than after
+        the `DOMContentLoaded` event is fired. This means that it's guaranteed to exist before any
+        interface/view code runs.
+
+        * UserInterface/Debug/Bootstrap.js:
+        (WI.runBootstrapOperations):
+
 2019-08-12  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js

@@ -38 +38 @@
 }, WI.settings.engineeringShowInternalScripts);
 
+WI.showDebugUISetting = new WI.Setting("show-debug-ui", false);
+
 // This function is invoked after the inspector has loaded and has a backend target.
 WI.runBootstrapOperations = function() {
-    WI.showDebugUISetting = new WI.Setting("show-debug-ui", false);
-
     // Toggle Debug UI setting.
     new WI.KeyboardShortcut(WI.KeyboardShortcut.Modifier.Option | WI.KeyboardShortcut.Modifier.Shift | WI.KeyboardShortcut.Modifier.CommandOrControl, "D", () => {