Changeset 248633 in webkit


Ignore:
Timestamp:
Aug 13, 2019 1:58:19 PM (5 years ago)
Author:
Chris Dumez
Message:

Fix potential thread safety issue under StorageManager::getSessionStorageOrigins()
https://bugs.webkit.org/show_bug.cgi?id=200684

Reviewed by Geoffrey Garen.

Fix potential thread safety issue under StorageManager::getSessionStorageOrigins(). The origins are being
passed from the background queue to the main thread without isolated copy.

  • NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::getSessionStorageOrigins):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r248631 r248633  
     12019-08-13  Chris Dumez  <cdumez@apple.com>
     2
     3        Fix potential thread safety issue under StorageManager::getSessionStorageOrigins()
     4        https://bugs.webkit.org/show_bug.cgi?id=200684
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Fix potential thread safety issue under StorageManager::getSessionStorageOrigins(). The origins are being
     9        passed from the background queue to the main thread without isolated copy.
     10
     11        * NetworkProcess/WebStorage/StorageManager.cpp:
     12        (WebKit::StorageManager::getSessionStorageOrigins):
     13
    1142019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
    215
  • trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp

    r248543 r248633  
    181181        for (const auto& sessionStorageNamespace : m_sessionStorageNamespaces.values()) {
    182182            for (auto& origin : sessionStorageNamespace->origins())
    183                 origins.add(origin);
     183                origins.add(crossThreadCopy(origin));
    184184        }
    185185
Note: See TracChangeset for help on using the changeset viewer.