Changeset 248634 in webkit

Timestamp:

Aug 13, 2019 2:00:49 PM (5 years ago)

Author:

Chris Dumez

Message:

Fix potential thread safety issue under WebResourceLoadStatisticsStore::hasHadUserInteraction()
​https://bugs.webkit.org/show_bug.cgi?id=200688

Reviewed by Alex Christensen.

Fix potential thread safety issue under WebResourceLoadStatisticsStore::hasHadUserInteraction().
It passes a RegistrableDomain to another thread without isolated copying it.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-13  Chris Dumez  <cdumez@apple.com>
+
+        Fix potential thread safety issue under WebResourceLoadStatisticsStore::hasHadUserInteraction()
+        https://bugs.webkit.org/show_bug.cgi?id=200688
+
+        Reviewed by Alex Christensen.
+
+        Fix potential thread safety issue under WebResourceLoadStatisticsStore::hasHadUserInteraction().
+        It passes a RegistrableDomain to another thread without isolated copying it.
+
+        * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
+        (WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):
+
 2019-08-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp

@@ -601 +601 @@
     ASSERT(RunLoop::isMain());
 
-    postTask([this, domain, completionHandler = WTFMove(completionHandler)]() mutable {
+    postTask([this, domain = domain.isolatedCopy(), completionHandler = WTFMove(completionHandler)]() mutable {
         bool hadUserInteraction = m_statisticsStore ? m_statisticsStore->hasHadUserInteraction(domain, OperatingDatesWindow::Long) : false;
         postTaskReply([hadUserInteraction, completionHandler = WTFMove(completionHandler)]() mutable {