Changeset 248637 in webkit

Timestamp:

Aug 13, 2019 3:14:49 PM (5 years ago)

Author:

Joseph Pecoraro

Message:

Uncaught Exception: content.isJSON is not a function selecting image resource
​https://bugs.webkit.org/show_bug.cgi?id=200680

Reviewed by Devin Rousso.

• UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype._canUseJSONContentViewForContent):
Protect against non-string data, such as Blob response content.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ResourceClusterContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-13  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Uncaught Exception: content.isJSON is not a function selecting image resource
+        https://bugs.webkit.org/show_bug.cgi?id=200680
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/ResourceClusterContentView.js:
+        (WI.ResourceClusterContentView.prototype._canUseJSONContentViewForContent):
+        Protect against non-string data, such as Blob response content.
+
 2019-08-13  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js

@@ -343 +343 @@
     _canUseJSONContentViewForContent(content)
     {
-        return content.isJSON((json) => json && (typeof json === "object" || Array.isArray(json)));
+        return typeof content === "string" && content.isJSON((json) => json && (typeof json === "object" || Array.isArray(json)));
     }