Changeset 248648 in webkit

Timestamp:

Aug 13, 2019 5:31:49 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Focus rings are black
​https://bugs.webkit.org/show_bug.cgi?id=200593
<rdar://problem/54145925>

Patch by Daniel Bates <​dabates@apple.com> on 2019-08-13
Reviewed by Wenson Hsieh.

Work around <rdar://problem/50838886> and make focus rings a pretty blue.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::platformFocusRingColor const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-13  Daniel Bates  <dabates@apple.com>
+
+        Focus rings are black
+        https://bugs.webkit.org/show_bug.cgi?id=200593
+        <rdar://problem/54145925>
+
+        Reviewed by Wenson Hsieh.
+
+        Work around <rdar://problem/50838886> and make focus rings a pretty blue.
+
+        * rendering/RenderThemeIOS.mm:
+        (WebCore::RenderThemeIOS::platformFocusRingColor const):
+
 2019-08-13  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/RenderThemeIOS.mm

@@ -1133 +1133 @@
 Color RenderThemeIOS::platformFocusRingColor(OptionSet<StyleColor::Options>) const
 {
-    return colorFromUIColor([PAL::getUIColorClass() keyboardFocusIndicatorColor]);
+    // FIXME: Should be using -keyboardFocusIndicatorColor. For now, work around <rdar://problem/50838886>.
+    return colorFromUIColor([PAL::getUIColorClass() systemBlueColor]);
 }
 #endif