Changeset 248656 in webkit

Timestamp:

Aug 13, 2019 6:36:26 PM (5 years ago)

Author:

rmorisset@apple.com

Message:

[WHLSL] Move Qualifiers and Semantic from VariableDeclaration to VariableDeclaration::RareData
​https://bugs.webkit.org/show_bug.cgi?id=200696

Reviewed by Myles C. Maxfield.

Shrinking VariableDeclaration by 16 bytes in the common case.

No new tests as there is no intended functional change.

• Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-13  Robin Morisset  <rmorisset@apple.com>
+
+        [WHLSL] Move Qualifiers and Semantic from VariableDeclaration to VariableDeclaration::RareData
+        https://bugs.webkit.org/show_bug.cgi?id=200696
+
+        Reviewed by Myles C. Maxfield.
+
+        Shrinking VariableDeclaration by 16 bytes in the common case.
+
+        No new tests as there is no intended functional change.
+
+        * Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
+
 2019-08-13  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h

@@ -48 +48 @@
 // Final because we made the destructor non-virtual.
 public:
+    struct RareData {
+        RareData(Qualifiers&& qualifiersArgument, std::unique_ptr<Semantic>&& semanticArgument)
+            : qualifiers(WTFMove(qualifiersArgument))
+            , semantic(WTFMove(semanticArgument))
+        {
+        }
+        Qualifiers qualifiers;
+        std::unique_ptr<Semantic> semantic;
+    };
+
     VariableDeclaration(CodeLocation codeLocation, Qualifiers&& qualifiers, RefPtr<UnnamedType> type, String&& name, std::unique_ptr<Semantic>&& semantic, std::unique_ptr<Expression>&& initializer)
         : m_codeLocation(codeLocation)
-        , m_qualifiers(WTFMove(qualifiers))
         , m_type(WTFMove(type))
+        , m_initializer(WTFMove(initializer))
         , m_name(WTFMove(name))
-        , m_semantic(WTFMove(semantic))
-        , m_initializer(WTFMove(initializer))
     {
+        if (semantic || !qualifiers.isEmpty())
+            m_rareData = std::make_unique<RareData>(WTFMove(qualifiers), WTFMove(semantic));
     }
 
@@ -75 +85 @@
     const RefPtr<UnnamedType>& type() const { return m_type; }
     UnnamedType* type() { return m_type ? &*m_type : nullptr; }
-    Semantic* semantic() { return m_semantic.get(); }
     Expression* initializer() { return m_initializer.get(); }
     bool isAnonymous() const { return m_name.isNull(); }
@@ -87 +96 @@
     CodeLocation codeLocation() const { return m_codeLocation; }
 
+    Semantic* semantic() { return m_rareData ? m_rareData->semantic.get() : nullptr; }
+
 private:
     CodeLocation m_codeLocation;
-    Qualifiers m_qualifiers;
     RefPtr<UnnamedType> m_type;
+    std::unique_ptr<Expression> m_initializer;
+    std::unique_ptr<RareData> m_rareData { nullptr };
     String m_name;
-    std::unique_ptr<Semantic> m_semantic;
-    std::unique_ptr<Expression> m_initializer;
 };