Changeset 248706 in webkit
- Timestamp:
- Aug 14, 2019 8:36:22 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r248695 r248706 1 2019-08-14 Myles C. Maxfield <mmaxfield@apple.com> 2 3 [WHLSL] Variables shouldn't be able to have void type 4 https://bugs.webkit.org/show_bug.cgi?id=200751 5 6 Reviewed by Robin Morisset. 7 8 * webgpu/whlsl/void-variable-parameter-expected.txt: Added. 9 * webgpu/whlsl/void-variable-parameter.html: Added. 10 1 11 2019-08-14 Zalan Bujtas <zalan@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r248704 r248706 1 2019-08-14 Myles C. Maxfield <mmaxfield@apple.com> 2 3 [WHLSL] Variables shouldn't be able to have void type 4 https://bugs.webkit.org/show_bug.cgi?id=200751 5 6 Reviewed by Robin Morisset. 7 8 Trivial fix. Found by https://github.com/gpuweb/WHLSL/issues/320. 9 10 Test: webgpu/whlsl/void-variable-parameter.html 11 12 * Modules/webgpu/WHLSL/WHLSLChecker.cpp: 13 (WebCore::WHLSL::Checker::visit): 14 1 15 2019-08-14 Justin Fan <justin_fan@apple.com> 2 16 -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
r248650 r248706 953 953 // and that doesn't recurse on the anonymous variables, so we can assume the variable has a type. 954 954 checkErrorAndVisit(*variableDeclaration.type()); 955 if (matches(*variableDeclaration.type(), m_intrinsics.voidType())) { 956 setError(Error("Variables can't have void type.", variableDeclaration.codeLocation())); 957 return; 958 } 955 959 if (variableDeclaration.initializer()) { 956 960 auto& lhsType = *variableDeclaration.type();
Note: See TracChangeset
for help on using the changeset viewer.