Changeset 248708 in webkit
- Timestamp:
- Aug 14, 2019 11:11:35 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/imported/w3c/ChangeLog
r248705 r248708 1 2019-08-14 Alexey Shvayka <shvaikalesh@gmail.com> 2 3 Error thrown during "acceptNode" lookup is overridden 4 https://bugs.webkit.org/show_bug.cgi?id=200735 5 6 Reviewed by Ross Kirsling. 7 8 * web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter-expected.txt: 9 1 10 2019-08-14 Alexey Shvayka <shvaikalesh@gmail.com> 2 11 -
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter-expected.txt
r248705 r248708 8 8 PASS Testing with function having acceptNode function 9 9 PASS Testing with filter function that throws 10 FAIL rethrows errors when getting `acceptNode` assert_throws: function "function () { walker.firstChild(); }" threw object "TypeError: Type error" ("TypeError") expected object "[object Object]" ("test") 10 PASS rethrows errors when getting `acceptNode` 11 11 PASS performs `Get` on every traverse 12 12 PASS Testing with filter object that throws -
trunk/Source/WebCore/ChangeLog
r248706 r248708 1 2019-08-14 Alexey Shvayka <shvaikalesh@gmail.com> 2 3 Error thrown during "acceptNode" lookup is overridden 4 https://bugs.webkit.org/show_bug.cgi?id=200735 5 6 Reviewed by Ross Kirsling. 7 8 Test: imported/w3c/web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter-expected.html 9 10 * bindings/js/JSCallbackData.cpp: 11 (WebCore::JSCallbackData::invokeCallback): Catch and return exception of callback->get call. 12 1 13 2019-08-14 Myles C. Maxfield <mmaxfield@apple.com> 2 14 -
trunk/Source/WebCore/bindings/js/JSCallbackData.cpp
r235271 r248708 45 45 ExecState* exec = globalObject.globalExec(); 46 46 VM& vm = exec->vm(); 47 auto scope = DECLARE_CATCH_SCOPE(vm); 48 47 49 JSValue function; 48 50 CallData callData; … … 61 63 ASSERT(!functionName.isNull()); 62 64 function = callback->get(exec, functionName); 65 if (UNLIKELY(scope.exception())) { 66 returnedException = scope.exception(); 67 scope.clearException(); 68 return JSValue(); 69 } 70 63 71 callType = getCallData(vm, function, callData); 64 72 if (callType == CallType::None) {
Note: See TracChangeset
for help on using the changeset viewer.