Changeset 248741 in webkit

Timestamp:

Aug 15, 2019 1:21:05 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Yellow Lookup highlight gets stuck over Mail messages
​https://bugs.webkit.org/show_bug.cgi?id=200778
<rdar://problem/53868514>

Reviewed by Wenson Hsieh.

• WebView/WebView.mm:

(-[WebView _showDictionaryLookupPopup:]):
Add a dismissal callback so that when Reveal hides the panel, it also
dismisses the yellow indicator. This matches the behavior in modern WebKit.

Location:

trunk/Source/WebKitLegacy/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebView.mm (modified) (2 diffs)

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2019-08-15  Tim Horton  <timothy_horton@apple.com>
+
+        Yellow Lookup highlight gets stuck over Mail messages
+        https://bugs.webkit.org/show_bug.cgi?id=200778
+        <rdar://problem/53868514>
+
+        Reviewed by Wenson Hsieh.
+
+        * WebView/WebView.mm:
+        (-[WebView _showDictionaryLookupPopup:]):
+        Add a dismissal callback so that when Reveal hides the panel, it also
+        dismisses the yellow indicator. This matches the behavior in modern WebKit.
+
 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebKitLegacy/mac/WebView/WebView.mm

@@ -247 +247 @@
 #import <wtf/SoftLinking.h>
 #import <wtf/StdLibExtras.h>
+#import <wtf/WeakObjCPtr.h>
 #import <wtf/WorkQueue.h>
 #import <wtf/spi/darwin/dyldSPI.h>
@@ -9508 +9509 @@
     }, [self](FloatRect rectInRootViewCoordinates) {
         return [self _convertRectFromRootView:rectInRootViewCoordinates];
+    }, [weakSelf = WeakObjCPtr<WebView>(self)]() {
+        [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut];
     });
 }