Changeset 248754 in webkit

Timestamp:

Aug 15, 2019 6:39:34 PM (5 years ago)

Author:

mmaxfield@apple.com

Message:

[WHLSL] Matrices should have constructors that take a flattened list of scalars
​https://bugs.webkit.org/show_bug.cgi?id=200804

Reviewed by Saam Barati.

Source/WebCore:

HLSL has them, so we should too.

Test: webgpu/whlsl/matrix-constructors-list-of-scalars.html

• Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:

LayoutTests:

• webgpu/whlsl/matrix-constructors-list-of-scalars-expected.txt: Added.
• webgpu/whlsl/matrix-constructors-list-of-scalars.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webgpu/whlsl/matrix-constructors-list-of-scalars-expected.txt (added)
• LayoutTests/webgpu/whlsl/matrix-constructors-list-of-scalars.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-15  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Matrices should have constructors that take a flattened list of scalars
+        https://bugs.webkit.org/show_bug.cgi?id=200804
+
+        Reviewed by Saam Barati.
+
+        * webgpu/whlsl/matrix-constructors-list-of-scalars-expected.txt: Added.
+        * webgpu/whlsl/matrix-constructors-list-of-scalars.html: Added.
+
 2019-08-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-15  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Matrices should have constructors that take a flattened list of scalars
+        https://bugs.webkit.org/show_bug.cgi?id=200804
+
+        Reviewed by Saam Barati.
+
+        HLSL has them, so we should too.
+
+        Test: webgpu/whlsl/matrix-constructors-list-of-scalars.html
+
+        * Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:
+
 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt

@@ -13197 +13197 @@
     return result;
 }
-
+operator float2x2(float a, float b, float e, float f) {
+    return float2x2(float2(a, b), float2(e, f));
+}
+operator float2x3(float a, float b, float c, float e, float f, float g) {
+    return float2x3(float3(a, b, c), float3(e, f, g));
+}
+operator float2x4(float a, float b, float c, float d, float e, float f, float g, float h) {
+    return float2x4(float4(a, b, c, d), float4(e, f, g, h));
+}
+operator float3x2(float a, float b, float e, float f, float i, float j) {
+    return float3x2(float2(a, b), float2(e, f), float2(i, j));
+}
+operator float3x3(float a, float b, float c, float e, float f, float g, float i, float j, float k) {
+    return float3x3(float3(a, b, c), float3(e, f, g), float3(i, j, k));
+}
+operator float3x4(float a, float b, float c, float d, float e, float f, float g, float h, float i, float j, float k, float l) {
+    return float3x4(float4(a, b, c, d), float4(e, f, g, h), float4(i, j, k, l));
+}
+operator float4x2(float a, float b, float e, float f, float i, float j, float m, float n) {
+    return float4x2(float2(a, b), float2(e, f), float2(i, j), float2(m, n));
+}
+operator float4x3(float a, float b, float c, float e, float f, float g, float i, float j, float k, float m, float n, float o) {
+    return float4x3(float3(a, b, c), float3(e, f, g), float3(i, j, k), float3(m, n, o));
+}
+operator float4x4(float a, float b, float c, float d, float e, float f, float g, float h, float i, float j, float k, float l, float m, float n, float o, float p) {
+    return float4x4(float4(a, b, c, d), float4(e, f, g, h), float4(i, j, k, l), float4(m, n, o, p));
+}
 
 /* Functions named operator.wyx */