Changeset 248772 in webkit

Timestamp:

Aug 16, 2019 8:48:03 AM (5 years ago)

Author:

Antti Koivisto

Message:

Content in <iframe> should override "touch-action" set in embedding document
​https://bugs.webkit.org/show_bug.cgi?id=200204
<rdar://problem/54355249>

Reviewed by Antoine Quint.

Source/WebCore:

Test: pointerevents/ios/touch-action-region-frame.html

Subframes where content doesn't use any touch-action properties won't generate event region for their main layer.
As a result the touch-action property gets computed in UI process to the parent frames touch-action (instead of 'auto').

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

Generate event region for the main layer of subframes.

LayoutTests:

• pointerevents/ios/touch-action-region-frame-expected.txt: Added.
• pointerevents/ios/touch-action-region-frame.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/pointerevents/ios/touch-action-region-frame-expected.txt (added)
• LayoutTests/pointerevents/ios/touch-action-region-frame.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-16  Antti Koivisto  <antti@apple.com>
+
+        Content in <iframe> should override "touch-action" set in embedding document
+        https://bugs.webkit.org/show_bug.cgi?id=200204
+        <rdar://problem/54355249>
+
+        Reviewed by Antoine Quint.
+
+        * pointerevents/ios/touch-action-region-frame-expected.txt: Added.
+        * pointerevents/ios/touch-action-region-frame.html: Added.
+
 2019-08-16  Chris Lord  <clord@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-16  Antti Koivisto  <antti@apple.com>
+
+        Content in <iframe> should override "touch-action" set in embedding document
+        https://bugs.webkit.org/show_bug.cgi?id=200204
+        <rdar://problem/54355249>
+
+        Reviewed by Antoine Quint.
+
+        Test: pointerevents/ios/touch-action-region-frame.html
+
+        Subframes where content doesn't use any touch-action properties won't generate event region for their main layer.
+        As a result the touch-action property gets computed in UI process to the parent frames touch-action (instead of 'auto').
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateEventRegion):
+
+        Generate event region for the main layer of subframes.
+
 2019-08-16  Miguel Gomez  <magomez@igalia.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1589 +1589 @@
     hasTouchActionElements = renderer().document().mayHaveElementsWithNonAutoTouchAction();
 #endif
-    if (m_owningLayer.isRenderViewLayer() && !hasTouchActionElements)
+    if (m_isMainFrameRenderViewLayer && !hasTouchActionElements)
         return;