Changeset 248858 in webkit

Timestamp:

Aug 19, 2019 10:51:47 AM (5 years ago)

Author:

Jonathan Bedard

Message:

results-webkit.org: Add timeout to Redis locks
​https://bugs.webkit.org/show_bug.cgi?id=200890

Reviewed by Aakash Jain.

• resultsdbpy/resultsdbpy/model/upload_context.py:

(UploadContext._find_job_with_attempts): Add timeout to Redis lock.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/model/upload_context.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-19  Jonathan Bedard  <jbedard@apple.com>
+
+        results-webkit.org: Add timeout to Redis locks
+        https://bugs.webkit.org/show_bug.cgi?id=200890
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/model/upload_context.py:
+        (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
+
 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py

@@ -128 +128 @@
         will_attempt = 0
 
-        with self.redis.lock(name=f'lock_{self.QUEUE_NAME}'):
+        with self.redis.lock(name=f'lock_{self.QUEUE_NAME}', timeout=60):
             for key in self.redis.scan_iter(match=f'{self.QUEUE_NAME}*', count=self.MAX_TASKS_IN_SCAN):
                 are_jobs_left = True