Changeset 248872 in webkit

Timestamp:

Aug 19, 2019 3:16:15 PM (5 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] DFG DataView get/set optimization should take care of the case little-endian flag is JSEmpty
​https://bugs.webkit.org/show_bug.cgi?id=200899
<rdar://problem/54073341>

Reviewed by Mark Lam.

JSTests:

• stress/data-view-get-dfg-should-handle-empty-constant.js: Added.

(i.new.Promise):

• stress/data-view-set-dfg-should-handle-empty-constant.js: Added.

(i.new.Promise):

Source/JavaScriptCore:

DFGByteCodeParser attempt to get constant flag for isLittleEndian for DataView get/set.
When getting a constant in DFG, we first need to check whether it is JSEmpty. But we are missing
this check for DataView get/set optimization.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/data-view-get-dfg-should-handle-empty-constant.js (added)
• JSTests/stress/data-view-set-dfg-should-handle-empty-constant.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] DFG DataView get/set optimization should take care of the case little-endian flag is JSEmpty
+        https://bugs.webkit.org/show_bug.cgi?id=200899
+        <rdar://problem/54073341>
+
+        Reviewed by Mark Lam.
+
+        * stress/data-view-get-dfg-should-handle-empty-constant.js: Added.
+        (i.new.Promise):
+        * stress/data-view-set-dfg-should-handle-empty-constant.js: Added.
+        (i.new.Promise):
+
 2019-08-19  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] DFG DataView get/set optimization should take care of the case little-endian flag is JSEmpty
+        https://bugs.webkit.org/show_bug.cgi?id=200899
+        <rdar://problem/54073341>
+
+        Reviewed by Mark Lam.
+
+        DFGByteCodeParser attempt to get constant flag for isLittleEndian for DataView get/set.
+        When getting a constant in DFG, we first need to check whether it is JSEmpty. But we are missing
+        this check for DataView get/set optimization.
+
+        * dfg/DFGByteCodeParser.cpp:
+        (JSC::DFG::ByteCodeParser::handleIntrinsicCall):
+
 2019-08-19  Tadeu Zagallo  <tzagallo@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

@@ -3245 +3245 @@
                     if (littleEndianChild->hasConstant()) {
                         JSValue constant = littleEndianChild->constant()->value();
-                        isLittleEndian = constant.pureToBoolean();
-                        if (isLittleEndian != MixedTriState)
-                            littleEndianChild = nullptr;
+                        if (constant) {
+                            isLittleEndian = constant.pureToBoolean();
+                            if (isLittleEndian != MixedTriState)
+                                littleEndianChild = nullptr;
+                        }
                     } else
                         isLittleEndian = MixedTriState;
@@ -3328 +3330 @@
                     if (littleEndianChild->hasConstant()) {
                         JSValue constant = littleEndianChild->constant()->value();
-                        isLittleEndian = constant.pureToBoolean();
-                        if (isLittleEndian != MixedTriState)
-                            littleEndianChild = nullptr;
+                        if (constant) {
+                            isLittleEndian = constant.pureToBoolean();
+                            if (isLittleEndian != MixedTriState)
+                                littleEndianChild = nullptr;
+                        }
                     } else
                         isLittleEndian = MixedTriState;