Changeset 248885 in webkit

Timestamp:

Aug 19, 2019 6:57:56 PM (5 years ago)

Author:

Fujii Hironori

Message:

[WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
​https://bugs.webkit.org/show_bug.cgi?id=200493

Reviewed by Ross Kirsling.

Reverted r179962.

• WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.

• WebCoreSupport/AcceleratedCompositingContext.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Location:

trunk/Source/WebKitLegacy/win

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/AcceleratedCompositingContext.cpp (modified) (2 diffs)
• WebCoreSupport/AcceleratedCompositingContext.h (modified) (1 diff)
• WebView.cpp (modified) (1 diff)

trunk/Source/WebKitLegacy/win/ChangeLog

@@ +1 @@
+2019-08-19  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
+        https://bugs.webkit.org/show_bug.cgi?id=200493
+
+        Reviewed by Ross Kirsling.
+
+        Reverted r179962.
+
+        * WebCoreSupport/AcceleratedCompositingContext.cpp:
+        (AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.
+        * WebCoreSupport/AcceleratedCompositingContext.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.cpp

@@ -30 +30 @@
 #include "WebView.h"
 
-#include <WebCore/DefWndProcWindowClass.h>
 #include <WebCore/Document.h>
 #include <WebCore/Frame.h>
 #include <WebCore/FrameView.h>
 #include <WebCore/GraphicsLayerTextureMapper.h>
-#include <WebCore/HWndDC.h>
 #include <WebCore/Page.h>
 #include <WebCore/Settings.h>
@@ -266 +264 @@
 }
 
-bool AcceleratedCompositingContext::acceleratedCompositingAvailable()
-{
-    const int width = 10;
-    const int height = 10;
-
-    // ANGLE requires Win7 or later.
-    if (windowsVersion() < Windows7)
-        return false;
-
-    // Create test window to render texture in.
-    HWND testWindow = ::CreateWindowEx(WS_EX_NOACTIVATE, defWndProcWindowClassName(), L"AcceleratedCompositingTesterWindow", WS_POPUP | WS_VISIBLE | WS_DISABLED, -width, -height, width, height, 0, 0, 0, 0);
-
-    if (!testWindow)
-        return false;
-
-    // Create GL context.
-    std::unique_ptr<WebCore::GLContext> context = GLContext::createContextForWindow(testWindow);
-
-    if (!context) {
-        ::DestroyWindow(testWindow);
-        return false;
-    }
-
-    context->makeContextCurrent();
-
-    std::unique_ptr<WebCore::TextureMapper> textureMapper = TextureMapperGL::create();
-
-    if (!textureMapper) {
-        ::DestroyWindow(testWindow);
-        return false;
-    }
-
-    // Create texture.
-    RefPtr<BitmapTexture> texture = textureMapper->createTexture();
-
-    if (!texture) {
-        ::DestroyWindow(testWindow);
-        return false;
-    }
-
-    texture->reset(IntSize(width, height));
-
-    // Copy bitmap data to texture.
-    const int bitmapSize = width * height;
-    int data[bitmapSize];
-    const COLORREF colorRed = RGB(255, 0, 0);
-    const COLORREF colorGreen = RGB(0, 255, 0);
-    for (int i = 0; i < bitmapSize; i++)
-        data[i] = colorGreen;
-    IntRect targetRect(0, 0, width, height);
-    IntPoint offset(0, 0);
-    int bytesPerLine = width * 4;
-    texture->updateContents(data, targetRect, offset, bytesPerLine);
-
-    // Render texture.
-    textureMapper->beginPainting();
-    FloatRect rect(0, 0, width, height);
-    textureMapper->drawTexture(*texture, rect);
-    textureMapper->endPainting();
-
-    // Set color of pixel (0, 0) to red, to make sure it is different from the bitmap color.
-    HWndDC hdc(testWindow);
-    ::SetPixel(hdc, 0, 0, colorRed);
-
-    context->swapBuffers();
-
-    // Check if pixel (0, 0) has expected color.
-    COLORREF pixelColor = ::GetPixel(hdc, 0, 0);
-
-    ::DestroyWindow(testWindow);
-
-    return pixelColor == colorGreen;
-}
-
 void AcceleratedCompositingContext::scheduleLayerFlush()
 {

trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.h

@@ -67 +67 @@
     void scrollNonCompositedContents(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset);
 
-    static bool acceleratedCompositingAvailable();
-
 private:
     WebView& m_webView;

trunk/Source/WebKitLegacy/win/WebView.cpp

@@ -5478 +5478 @@
     if (FAILED(hr))
         return hr;
-#if USE(TEXTURE_MAPPER_GL)
-    static bool acceleratedCompositingAvailable = AcceleratedCompositingContext::acceleratedCompositingAvailable();
-    enabled = enabled && acceleratedCompositingAvailable;
-#elif USE(DIRECT2D)
+#if USE(DIRECT2D)
     // Disable accelerated compositing for now.
     enabled = false;