Changeset 248927 in webkit

Timestamp:

Aug 20, 2019 5:39:02 PM (5 years ago)

Author:

mark.lam@apple.com

Message:

JSBigInt::m_length should be immutable.
​https://bugs.webkit.org/show_bug.cgi?id=200956

Reviewed by Yusuke Suzuki.

This is because the JSBigInt cell size is allocated with that length. Changing
the length after construction does not change the size of the cell, and hence,
makes no sense.

This patch removes the setLength() method, and decorates the m_length field with
const to enforce that it is immutable after construction.

• runtime/JSBigInt.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSBigInt.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-08-20  Mark Lam  <mark.lam@apple.com>
+
+        JSBigInt::m_length should be immutable.
+        https://bugs.webkit.org/show_bug.cgi?id=200956
+
+        Reviewed by Yusuke Suzuki.
+
+        This is because the JSBigInt cell size is allocated with that length.  Changing
+        the length after construction does not change the size of the cell, and hence,
+        makes no sense.
+
+        This patch removes the setLength() method, and decorates the m_length field with
+        const to enforce that it is immutable after construction.
+
+        * runtime/JSBigInt.h:
+
 2019-08-20  Devin Rousso  <drousso@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSBigInt.h

@@ -1 +1 @@
 /*
  * Copyright (C) 2017 Caio Lima <ticaiolima@gmail.com>
+ * Copyright (C) 2019 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -72 +73 @@
     bool sign() const { return m_sign; }
 
-    void setLength(unsigned length) { m_length = length; }
     unsigned length() const { return m_length; }
 
@@ -247 +247 @@
     Digit digit(unsigned);
     void setDigit(unsigned, Digit);
-        
-    unsigned m_length;
+
+    const unsigned m_length;
     bool m_sign { false };
 };