Changeset 248953 in webkit


Ignore:
Timestamp:
Aug 21, 2019 11:47:59 AM (5 years ago)
Author:
russell_e@apple.com
Message:

Unreviewed, rolling out r248942.

Causes multiple layout test crashes on MacOS Bots

Reverted changeset:

"Verify Prefetch and credential behavior"
​https://bugs.webkit.org/show_bug.cgi?id=200000
​https://trac.webkit.org/changeset/248942

Location:
trunk
Files:
5 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r248943 r248953  
     12019-08-21  Russell Epstein  <repstein@apple.com>
     2
     3        Unreviewed, rolling out r248942.
     4
     5        Causes multiple layout test crashes on MacOS Bots
     6
     7        Reverted changeset:
     8
     9        "Verify Prefetch and credential behavior"
     10        https://bugs.webkit.org/show_bug.cgi?id=200000
     11        https://trac.webkit.org/changeset/248942
     12
    1132019-08-21  Devin Rousso  <drousso@apple.com>
    214

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r248942 r248953  
    737737webkit.org/b/195623 http/tests/cache/link-prefetch-main-resource-iframe.html [ Skip ]
    738738
    739 # prefetch not supported in WK1
    740 http/wpt/prefetch [ Skip ]
     739webkit.org/b/197371 http/wpt/prefetch/link-prefetch-main-resource-redirect.html [ Skip ]
     740webkit.org/b/199499 http/wpt/prefetch/link-prefetch-skip-disk-cache.html [ Skip ]
     741
     742webkit.org/b/199632 http/wpt/prefetch/beforeload.html [ Skip ]
     743webkit.org/b/199632 http/wpt/prefetch/beforeload-dynamic.html [ Skip ]
    741744
    742745webkit.org/b/198177 pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html [ Skip ]

  • trunk/LayoutTests/platform/win/TestExpectations

    r248942 r248953  
    44234423webkit.org/b/195623 http/tests/cache/link-prefetch-main-resource-iframe.html [ Skip ]
    44244424
    4425 # prefetch not supported in WK1
    4426 http/wpt/prefetch [ Skip ]
     4425webkit.org/b/197371 http/wpt/prefetch/link-prefetch-main-resource-redirect.html [ Skip ]
     4426webkit.org/b/199499 http/wpt/prefetch/link-prefetch-skip-disk-cache.html [ Skip ]
     4427
     4428webkit.org/b/199632 http/wpt/prefetch/beforeload.html [ Skip ]
     4429webkit.org/b/199632 http/wpt/prefetch/beforeload-dynamic.html [ Skip ]
    44274430
    44284431webkit.org/b/198112 http/tests/security/showModalDialog-sync-cross-origin-page-load2.html [ Skip ]

  • trunk/Source/WebKit/ChangeLog

    r248950 r248953  
     12019-08-21  Russell Epstein  <repstein@apple.com>
     2
     3        Unreviewed, rolling out r248942.
     4
     5        Causes multiple layout test crashes on MacOS Bots
     6
     7        Reverted changeset:
     8
     9        "Verify Prefetch and credential behavior"
     10        https://bugs.webkit.org/show_bug.cgi?id=200000
     11        https://trac.webkit.org/changeset/248942
     12
    1132019-08-21  Keith Rollin  <krollin@apple.com>
    214

  • trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

    r248942 r248953  
    222222        if (auto* session = m_connection->networkProcess().networkSession(sessionID())) {
    223223            if (auto entry = session->prefetchCache().take(request.url())) {
     224                // FIXME: Deal with credentials (https://bugs.webkit.org/show_bug.cgi?id=200000)
    224225                if (!entry->redirectRequest.isNull()) {
    225226                    auto cacheEntry = m_cache->makeRedirectEntry(request, entry->response, entry->redirectRequest);
    … …  
    500501    }
    501502
    502     if (isCrossOriginPrefetch()) {
    503         if (response.httpHeaderField(HTTPHeaderName::Vary).contains("Cookie")) {
    504             abort();
    505             return completionHandler(PolicyAction::Ignore);
    506         }
     503    if (isCrossOriginPrefetch())
    507504        return completionHandler(PolicyAction::Use);
    508     }
    509505
    510506    // We wait to receive message NetworkResourceLoader::ContinueDidReceiveResponse before continuing a load for

  • trunk/Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp

    r248942 r248953  
    6666        return std::get<0>(tuple) == url;
    6767    });
    68     auto entry = resources->take(url);
    69     ASSERT(!entry->response.httpHeaderField(WebCore::HTTPHeaderName::Vary).contains("Cookie"));
    70     return entry;
     68    return resources->take(url);
    7169}
    7270
Note: See TracChangeset for help on using the changeset viewer.