Changeset 248976 in webkit

Timestamp:

Aug 21, 2019 4:56:24 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] view layout test results option should be displayed next to layout-test build step
​https://bugs.webkit.org/show_bug.cgi?id=200048

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
(ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1490 +1490 @@
         return self.zipFile.replace('public_html/', '/')
 
+    def getLastBuildStepByName(self, name):
+        for step in reversed(self.build.executedSteps):
+            if name in step.name:
+                return step
+        return None
+
     def addCustomURLs(self):
-        self.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
-        self.addURL('download layout test results', self.resultsDownloadURL())
+        step = self.getLastBuildStepByName(RunWebKitTests.name)
+        if not step:
+            step = self
+        step.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
+        step.addURL('download layout test results', self.resultsDownloadURL())
 
     def finished(self, result):

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-21  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] view layout test results option should be displayed next to layout-test build step
+        https://bugs.webkit.org/show_bug.cgi?id=200048
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
+        (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
+
 2019-08-21  Aakash Jain  <aakash_jain@apple.com>