Changeset 249014 in webkit

Timestamp:

Aug 22, 2019 9:42:57 AM (5 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Provide an engineering option to log protocol traffic as text
​https://bugs.webkit.org/show_bug.cgi?id=200969

Reviewed by Devin Rousso.

• UserInterface/Base/Setting.js:
• UserInterface/Protocol/LoggingProtocolTracer.js:

(WI.LoggingProtocolTracer.prototype._processEntry):
(WI.LoggingProtocolTracer):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createDebugSettingsView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Protocol/LoggingProtocolTracer.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-22  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Provide an engineering option to log protocol traffic as text
+        https://bugs.webkit.org/show_bug.cgi?id=200969
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Protocol/LoggingProtocolTracer.js:
+        (WI.LoggingProtocolTracer.prototype._processEntry):
+        (WI.LoggingProtocolTracer):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createDebugSettingsView):
+
 2019-08-21  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -190 +190 @@
 
     // Protocol
+    protocolLogAsText: new WI.Setting("protocol-log-as-text", false),
     protocolAutoLogMessages: new WI.Setting("protocol-auto-log-messages", false),
     protocolAutoLogTimeStats: new WI.Setting("protocol-auto-log-time-stats", false),

trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js

@@ -122 +122 @@
 
             let prefix = `${entry.type} (${targetId})`;
-            if (!window.InspectorTest && InspectorFrontendHost.isBeingInspected()) {
+            if (!window.InspectorTest && InspectorFrontendHost.isBeingInspected() && !WI.settings.protocolLogAsText.value) {
                 if (entry.type === "request" || entry.type === "exception")
                     console.trace(prefix, entry.message);

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -414 +414 @@
 
         protocolMessagesGroup.addSetting(WI.settings.protocolAutoLogTimeStats, WI.unlocalizedString("Time Stats"));
+        protocolMessagesGroup.addSetting(WI.settings.protocolLogAsText, WI.unlocalizedString("Log as Text"));
 
         this._debugSettingsView.addSeparator();