Changeset 249042 in webkit


Ignore:
Timestamp:
Aug 23, 2019 12:25:00 AM (5 years ago)
Author:
Megan Gardner
Message:

Revert delete-in-input-in-iframe.html and typing-in-input-in-iframe.html to original behaviour after r248977 and make associated test autoscroll-input-when-very-zoomed.html more stable
​https://bugs.webkit.org/show_bug.cgi?id=201058

Reviewed by Simon Fraser.

delete-in-input-in-iframe and typing-in-input-in-iframe were changed when scrolling was made to work differently in r244141.
They actually did find a bug, and that bug was fixed in r248977, so we put the tests back to test that scolls do not happen.
Also update autoscroll-input-when-very-zoomed which was added to test r248977 to be more robust.

  • fast/forms/ios/delete-in-input-in-iframe-expected.txt:
  • fast/forms/ios/delete-in-input-in-iframe.html:
  • fast/forms/ios/typing-in-input-in-iframe-expected.txt:
  • fast/forms/ios/typing-in-input-in-iframe.html:
  • fast/scrolling/ios/autoscroll-input-when-very-zoomed.html:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r249040 r249042  
     12019-08-23  Megan Gardner  <megan_gardner@apple.com>
     2
     3        Revert delete-in-input-in-iframe.html and typing-in-input-in-iframe.html to original behaviour after r248977 and make associated test autoscroll-input-when-very-zoomed.html more stable
     4        https://bugs.webkit.org/show_bug.cgi?id=201058
     5
     6        Reviewed by Simon Fraser.
     7
     8        delete-in-input-in-iframe and typing-in-input-in-iframe were changed when scrolling was made to work differently in r244141.
     9        They actually did find a bug, and that bug was fixed in r248977, so we put the tests back to test that scolls do not happen.
     10        Also update autoscroll-input-when-very-zoomed which was added to test r248977 to be more robust.
     11
     12        * fast/forms/ios/delete-in-input-in-iframe-expected.txt:
     13        * fast/forms/ios/delete-in-input-in-iframe.html:
     14        * fast/forms/ios/typing-in-input-in-iframe-expected.txt:
     15        * fast/forms/ios/typing-in-input-in-iframe.html:
     16        * fast/scrolling/ios/autoscroll-input-when-very-zoomed.html:
     17
    1182019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
    219

  • trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt

    r247571 r249042  
    11Tests that typing into a text input in an iframe should not scroll.
    22
    3 PASS: page scrolled to 1143
     3PASS: page did not scroll.
    44Click to focus input
    55

  • trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html

    r247571 r249042  
    4040    function pageDidScroll()
    4141    {
    42         document.getElementById('result').textContent = 'PASS: page scrolled to ' + document.scrollingElement.scrollTop;
     42        document.getElementById('result').textContent = 'FAIL: page scrolled to ' + document.scrollingElement.scrollTop;
    4343    }
    4444
    … …  
    7777<p>Tests that typing into a text input in an iframe should not scroll.</p>
    7878<div id="result">
    79     FAIL: page did not scroll.
     79    PASS: page did not scroll.
    8080</div>
    8181

  • trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe-expected.txt

    r247648 r249042  
    11Tests that typing into a text input in an iframe should not scroll.
    22
    3 PASS: page scrolled to 1143
     3PASS: page did not scroll.
    44Click to focus input
    55

  • trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe.html

    r247648 r249042  
    4040    function pageDidScroll()
    4141    {
    42         document.getElementById('result').textContent = 'PASS: page scrolled to ' + document.scrollingElement.scrollTop;
     42        document.getElementById('result').textContent = 'FAIL: page scrolled to ' + document.scrollingElement.scrollTop;
    4343    }
    4444
    … …  
    7777<p>Tests that typing into a text input in an iframe should not scroll.</p>
    7878<div id="result">
    79     FAIL: page did not scroll.
     79    PASS: page did not scroll.
    8080</div>
    8181

  • trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html

    r248977 r249042  
    2525        await UIHelper.immediateScrollTo(390, 390);
    2626
    27         await UIHelper.delayFor(200);
     27        await Promise.all([UIHelper.ensureVisibleContentRectUpdate(), UIHelper.ensureStablePresentationUpdate()]);
    2828
    2929        var originalXOffset = window.pageXOffset;
    … …  
    3636
    3737        // Scrolling is not immedate, wait until the viewport has time to adjust
    38         await UIHelper.delayFor(25);
     38        await Promise.all([UIHelper.ensureVisibleContentRectUpdate(), UIHelper.ensurePresentationUpdate()]);
    3939        await UIHelper.enterText("a");
    4040
    … …  
    4848                output += 'FAIL: page has failed to scrolled on the first input<br>';
    4949            if ((secondXOffset != finalXOffset) || (secondYOffset != finalYOffset))
    50                 output += 'FAIL: page has scrolled on the secont input';
     50                output += 'FAIL: page has scrolled on the second input';
    5151        }
    5252        output += '<br>';
Note: See TracChangeset for help on using the changeset viewer.