Changeset 249043 in webkit

Timestamp:

Aug 23, 2019 3:53:00 AM (5 years ago)

Author:

Philippe Normand

Message:

[GStreamer] Hole-punch build is broken
​https://bugs.webkit.org/show_bug.cgi?id=200972

Reviewed by Žan Doberšek.

This patch fixes link issues when building with
USE_GSTREAMER_HOLEPUNCH enabled, the hole punch client destructor
was missing.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Remove FAST_ALLOCATED annotation, because:

• platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:

it's now in the base class, along with a default destructor.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (modified) (1 diff)
• platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-23  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] Hole-punch build is broken
+        https://bugs.webkit.org/show_bug.cgi?id=200972
+
+        Reviewed by Žan Doberšek.
+
+        This patch fixes link issues when building with
+        USE_GSTREAMER_HOLEPUNCH enabled, the hole punch client destructor
+        was missing.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        Remove FAST_ALLOCATED annotation, because:
+        * platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
+        it's now in the base class, along with a default destructor.
+
 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

@@ -1126 +1126 @@
 
 class GStreamerHolePunchClient : public TextureMapperPlatformLayerBuffer::HolePunchClient {
-    WTF_MAKE_FAST_ALLOCATED;
 public:
     GStreamerHolePunchClient(GRefPtr<GstElement>&& videoSink) : m_videoSink(WTFMove(videoSink)) { };

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h

@@ -67 +67 @@
 
     class HolePunchClient {
+        WTF_MAKE_FAST_ALLOCATED();
     public:
+        virtual ~HolePunchClient() = default;
         virtual void setVideoRectangle(const IntRect&) = 0;
-        virtual ~HolePunchClient() = 0;
     };