Changeset 249188 in webkit


Ignore:
Timestamp:
Aug 27, 2019 6:40:42 PM (5 years ago)
Author:
Fujii Hironori
Message:

Make FrameLoader::open() set outgoing referrer properly
​https://bugs.webkit.org/show_bug.cgi?id=167050
Source/WebCore:

<rdar://problem/27972404>

Reviewed by Youenn Fablet.

In debug builds, an assertion failed in WebCore::SecurityPolicy::generateReferrerHeader:
ASSERTION FAILED: referrer == URL(URL(), referrer).strippedForUseAsReferrer()

In release builds, cached pages with a URL fragment sent its URL fragment in the referrer.

m_outgoingReferrer mistakenly had a URL fragment.

Test: http/tests/navigation/page-cache-fragment-referrer.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open): Set m_outgoingReferrer by using
FrameLoader::setOutgoingReferrer to remove URL fragments.

LayoutTests:

Reviewed by Youenn Fablet.

  • http/tests/navigation/page-cache-fragment-referrer-expected.html: Added.
  • http/tests/navigation/page-cache-fragment-referrer.html: Added.
  • http/tests/navigation/resources/referrer.php: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r249185 r249188  
     12019-08-27  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Make FrameLoader::open() set outgoing referrer properly
     4        https://bugs.webkit.org/show_bug.cgi?id=167050
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * http/tests/navigation/page-cache-fragment-referrer-expected.html: Added.
     9        * http/tests/navigation/page-cache-fragment-referrer.html: Added.
     10        * http/tests/navigation/resources/referrer.php: Added.
     11
    1122019-08-27  Devin Rousso  <drousso@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r249187 r249188  
     12019-08-27  John Wilander  <wilander@apple.com>  and  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Make FrameLoader::open() set outgoing referrer properly
     4        https://bugs.webkit.org/show_bug.cgi?id=167050
     5        <rdar://problem/27972404>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        In debug builds, an assertion failed in WebCore::SecurityPolicy::generateReferrerHeader:
     10        ASSERTION FAILED: referrer == URL(URL(), referrer).strippedForUseAsReferrer()
     11
     12        In release builds, cached pages with a URL fragment sent its URL fragment in the referrer.
     13
     14        m_outgoingReferrer mistakenly had a URL fragment.
     15
     16        Test: http/tests/navigation/page-cache-fragment-referrer.html
     17
     18        * loader/FrameLoader.cpp:
     19        (WebCore::FrameLoader::open): Set m_outgoingReferrer by using
     20        FrameLoader::setOutgoingReferrer to remove URL fragments.
     21
    1222019-08-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
    223

  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r248846 r249188  
    23102310    m_isComplete = false;
    23112311    m_didCallImplicitClose = false;
    2312     m_outgoingReferrer = url.string();
     2312    setOutgoingReferrer(url);
    23132313
    23142314    FrameView* view = cachedFrame.view();
Note: See TracChangeset for help on using the changeset viewer.